ro-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 6
Last Commit: 24 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 05 Nov
9:07 am

Michael Garthwaite

LDT-2116: removed manual level control out of pre gen mode. Permeate tank control will be sub mode specific. implemented in permeate flush to prevent overfill

Options
    • -0
    • +13
    ./FlushPermeate.c
    • -14
    • +1
    ./ModePreGenPermeate.c
Monday 03 Nov
9:10 am

Michael Garthwaite

LDT-2116: code review updates. Change target flow rate from 700 to 750 per system spec. Reverted debugging broadcast for RO Pump.

Options
    • -2
    • +3
    ./FlushConcentrate.c
    • -1
    • +1
    ./ModeGenPermeate.c
    • -1
    • +1
    ./ModePreGenPermeate.c
  4. … 2 more files in changeset.
Friday 31 Oct
8:50 am

Michael Garthwaite

LDT-2116: fixed handle function call where it shouldnt have been called.

Options
    • -1
    • +1
    ./FlushConcentrate.c
Thursday 30 Oct
1:54 pm

Michael Garthwaite

LDT-2116: Updates to pre gen tank control such that it does not recirculate water while in the op mode.

Options
    • -1
    • +2
    ./FPModeStandby.c
    • -1
    • +1
    ./FlushConcentrate.c
    • -2
    • +0
    ./FlushPermeate.c
    • -1
    • +15
    ./ModePreGenPermeate.c
Wednesday 29 Oct
8:43 am

Michael Garthwaite

LDT-2116: Added concentrate flush changes to keep the permeate tank full in pre-gen

Options
    • -16
    • +57
    ./FlushConcentrate.c
    • -1
    • +1
    ./ModePreGenPermeate.c
Thursday 04 Sep
1:19 pm

Raghu Kallala

LDT-1809 Resolved conflicts while merging staging

Options
    • -2
    • +2
    ./FlushConcentrate.c
    • -2
    • +2
    ./FlushPermeate.c
    • -1
    • +1
    ./ModePreGenPermeate.c
  4. … 1 more file in changeset.
Wednesday 03 Sep
2:28 pm

Shyam Kumar Mathamala <ven.smathamala@diality.com>

LDT-1735: fixed merge conflicts.

Options
    • -0
    • +368
    ./InletPressureCheck.c
  2. … 1 more file in changeset.
9:44 am

Michael Garthwaite

LDT-1242: code review comments. comment aligning. fix ro pump control calling set pwm pct when it should have been pwm cnt

Options
    • -2
    • +2
    ./FlushPermeate.c
    • -0
    • +1
    ./InletPressureCheck.c
    • -1
    • +1
    ./ModePreGenPermeate.c
  4. … 2 more files in changeset.
8:49 am

Michael Garthwaite

Merge branch 'staging' into LDT-1242-iofp-finalize-permeate-tank

Options
    • -1
    • +8
    ./ModePreGenPermeate.c
8:42 am

Michael Garthwaite

LDT-1242: added TODO for condition check when P7 is no longer available.

Options
    • -2
    • +2
    ./FlushConcentrate.c
Tuesday 02 Sep
11:10 am

Raghu Kallala

LDT-1809 latest from staging

Options
    • -1
    • +8
    ./ModePreGenPermeate.c
Friday 29 Aug
9:14 am

Michael Garthwaite

LDT-1242: updates to pre gen mode timeouts

Options
    • -2
    • +2
    ./FlushPermeate.c
    • -1
    • +1
    ./ModePreGenPermeate.c
Thursday 28 Aug
1:40 pm

Raghu Kallala

Updated ToDo check for inletpressurecheck init call

Options
    • -1
    • +1
    ./ModePreGenPermeate.c
8:51 am

Michael Garthwaite

LDT-1242: updated flow control curve. Renamed fp def op modes. Closing P39 on TANK FULL state

Options
    • -6
    • +6
    ./FPOperationModes.c
    • -1
    • +1
    ./ModeGenPermeateDefeatured.c
    • -1
    • +1
    ./ModePreGenPermeateDefeatured.c
  4. … 3 more files in changeset.
Wednesday 27 Aug
8:16 am

Raghu Kallala

Addressed review comment to remove flag assignment in paused state.

Options
    • -1
    • +0
    ./InletPressureCheck.c
Tuesday 26 Aug
10:37 am

Raghu Kallala

Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

Options
    • -1
    • +1
    ./FlushConcentrate.c
    • -1
    • +1
    ./FlushPermeate.c
    • -1
    • +1
    ./ModeGenPermeate.c
    • -1
    • +1
    ./ModePreGenPermeate.c
  5. … 2 more files in changeset.
Wednesday 20 Aug
6:31 am

Raghu Kallala

Addressed review comments.

Options
    • -7
    • +7
    ./InletPressureCheck.c
    • -4
    • +5
    ./InletPressureCheck.h
    • -0
    • +1
    ./ModePreGenPermeate.c
  4. … 1 more file in changeset.
Tuesday 19 Aug
10:24 am

Raghu Kallala

Addressed review comments to remove unwanted code lines and handled state assignment.

Options
    • -4
    • +1
    ./InletPressureCheck.c
    • -1
    • +0
    ./InletPressureCheck.h
    • -0
    • +1
    ./ModePreGenPermeate.c
Wednesday 13 Aug
3:41 pm

Michael Garthwaite

LDT-566: increased permeate flush timer to 5 minutes to support conductivity testing.

Options
    • -1
    • +1
    ./FlushPermeate.c
12:34 pm

Michael Garthwaite

LDT-566: moved valve enum from ro firmware repo to common repo

Options
    • -2
    • +2
    ./FPModeFault.c
  2. … 2 more files in changeset.
12:34 pm

Michael Garthwaite

LDT-566: moved valve enum from ro firmware repo to common repo

Options
    • -2
    • +2
    ./FPModeFault.c
  2. … 2 more files in changeset.
7:58 am

Raghu Kallala

Implemented Inlet Pressure check functionality with Boost Pump

Options
    • -0
    • +371
    ./InletPressureCheck.c
    • -0
    • +53
    ./InletPressureCheck.h
    • -1
    • +6
    ./ModePreGenPermeate.c
  4. … 3 more files in changeset.
Friday 01 Aug
3:56 pm

Michael Garthwaite

LDT-566: code review comments

Options
    • -1
    • +0
    ./FPModeStandby.c
    • -2
    • +0
    ./FlushConcentrate.c
    • -1
    • +0
    ./ModePreGenPermeate.c
    • -1
    • +0
    ./ModePreGenPermeateDefeatured.h
  5. … 10 more files in changeset.
12:22 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -2
    • +4
    ./ModeGenPermeateDefeatured.c
    • -7
    • +6
    ./ModeGenPermeateDefeatured.h
    • -4
    • +8
    ./ModePreGenPermeateDefeatured.c
    • -6
    • +6
    ./ModePreGenPermeateDefeatured.h
  5. … 2 more files in changeset.
12:08 pm

Michael Garthwaite

LDT-566: Code review comments. added reset calls in ro pump controllers when leaving off states. removed pressure check for boost pump.

Options
    • -0
    • +1
    ./FlushConcentrate.c
    • -0
    • +0
    ./PressureCheck.c
    • -15
    • +0
    ./PressureCheck.h
  4. … 5 more files in changeset.
Thursday 31 Jul
11:49 am

Michael Garthwaite

LDT-566: changed permeate flush to target flow. fixed output scaling for fluid pump. Target flow fixes

Options
    • -1
    • +1
    ./FlushPermeate.c
  2. … 5 more files in changeset.
Wednesday 30 Jul
1:30 pm

Michael Garthwaite

LDT-566: code review comments.

Options
    • -1
    • +1
    ./FPModeStandby.c
    • -19
    • +24
    ./FlushConcentrate.c
    • -2
    • +1
    ./FlushConcentrate.h
    • -10
    • +11
    ./FlushFilter.c
    • -9
    • +13
    ./FlushPermeate.c
    • -30
    • +13
    ./ModeGenPermeate.c
    • -9
    • +4
    ./ModeGenPermeate.h
  8. … 13 more files in changeset.
11:24 am

Michael Garthwaite

LDT-566: Permeate tank implementation. Changed RO control from pressure to flow for various sub modes. Alarm state and clear alarm overrides. Reworked temperature monitor to only publish.

Options
    • -9
    • +7
    ./FPModeFault.c
    • -5
    • +6
    ./FlushConcentrate.c
    • -6
    • +5
    ./FlushFilter.c
    • -7
    • +8
    ./FlushPermeate.c
    • -123
    • +11
    ./ModeGenPermeate.c
    • -4
    • +4
    ./ModeGenPermeateDefeatured.c
    • -24
    • +25
    ./ModePreGenPermeate.c
    • -12
    • +12
    ./ModePreGenPermeateDefeatured.c
  9. … 13 more files in changeset.
Tuesday 29 Jul
1:05 pm

Michael Garthwaite

LDT-566: Implemented FP fault mode. Removed math includes from flush modes.

Options
    • -19
    • +245
    ./FPModeFault.c
    • -1
    • +1
    ./FPModeFault.h
    • -3
    • +0
    ./FlushConcentrate.c
    • -2
    • +0
    ./FlushFilter.c
    • -3
    • +0
    ./FlushPermeate.c
    • -5
    • +5
    ./ModeGenPermeate.c
  7. … 2 more files in changeset.
12:15 pm

Michael Garthwaite

LDT-566: FP Safety shutdown override. fixed includes.

Options
    • -0
    • +1
    ./FPModeFault.c
    • -3
    • +6
    ./FPModeFault.h
    • -2
    • +2
    ./FPModeInitPOST.h
    • -2
    • +2
    ./FPModeStandby.h
    • -2
    • +2
    ./FPOperationModes.h
  6. … 8 more files in changeset.