ro-firmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 6
Last Commit: 24 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 29 Aug
8:56 am

Michael Garthwaite

LDT-1242: reverted flow control output for develop builds as pwm output requires tuning

Options
    • -7
    • +9
    ./Controllers/ROPump.c
Thursday 28 Aug
1:40 pm

Raghu Kallala

Updated ToDo check for inletpressurecheck init call

Options
    • -1
    • +1
    ./Modes/ModePreGenPermeate.c
9:39 am

Michael Garthwaite

LDT-1242: opening P34 on tank full state.

Options
    • -2
    • +2
    ./Controllers/PermeateTank.c
9:30 am

Michael Garthwaite

LDT-1242: converted RO flow control back to outputting PWM percentages instead of target mL/min.

Options
    • -13
    • +12
    ./Controllers/ROPump.c
8:51 am

Michael Garthwaite

LDT-1242: updated flow control curve. Renamed fp def op modes. Closing P39 on TANK FULL state

Options
    • -1
    • +1
    ./Controllers/PermeateTank.c
    • -2
    • +2
    ./Controllers/ROPump.c
    • -6
    • +6
    ./Modes/FPOperationModes.c
    • -1
    • +1
    ./Modes/ModeGenPermeateDefeatured.c
    • -1
    • +1
    ./Modes/ModePreGenPermeateDefeatured.c
    • -1
    • +1
    ./Services/DDInterface.c
Wednesday 27 Aug
2:54 pm

Raghu Kallala

Fixed indentation and review comments

Options
    • -18
    • +18
    ./Controllers/ROPump.c
8:16 am

Raghu Kallala

Addressed review comment to remove flag assignment in paused state.

Options
    • -1
    • +0
    ./Modes/InletPressureCheck.c
Tuesday 26 Aug
2:54 pm

Raghu Kallala

fixed review comments

Options
    • -30
    • +53
    ./Controllers/ROPump.c
    • -0
    • +55
    ./Drivers/FluidPump.c
    • -0
    • +2
    ./Drivers/FluidPump.h
10:37 am

Raghu Kallala

Fixed the issue to set targets to zero when a firmware call is made for set functions per review comments.

Options
    • -100
    • +62
    ./Controllers/ROPump.c
    • -3
    • +3
    ./Controllers/ROPump.h
    • -1
    • +1
    ./Modes/FlushConcentrate.c
    • -1
    • +1
    ./Modes/FlushPermeate.c
    • -1
    • +1
    ./Modes/ModeGenPermeate.c
    • -1
    • +1
    ./Modes/ModePreGenPermeate.c
Monday 25 Aug
4:52 pm

Shyam Kumar Mathamala <ven.smathamala@diality.com>

LDT-1735:Added Dialin Test Config Support

Options
    • -2
    • +86
    ./Services/Messaging.c
    • -0
    • +4
    ./Services/Messaging.h
12:40 pm

Michael Garthwaite

LDT-566: updated RO pwm flow curve from linear to logarithmic.

Options
    • -6
    • +7
    ./Controllers/ROPump.c
12:40 pm

Michael Garthwaite

LDT-566: updated RO pwm flow curve from linear to logarithmic.

Options
    • -6
    • +7
    ./Controllers/ROPump.c
12:13 pm

Shyam Kumar Mathamala <ven.smathamala@diality.com>

LDT-1735: Added support for Dialin command to set beta h/w.

Options
    • -9
    • +16
    ./Drivers/PressureSensor.c
Friday 22 Aug
3:21 pm

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./FPCommon.h
Wednesday 20 Aug
8:59 am

Raghu Kallala

removed commented code per review comments

Options
    • -1
    • +0
    ./Controllers/ROPump.c
8:23 am

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./FPCommon.h
8:21 am

Michael Garthwaite

LDT-828: fixed pressure sensor conversions for alpha units

Options
    • -7
    • +8
    ./Drivers/PressureSensor.c
6:31 am

Raghu Kallala

Addressed review comments.

Options
    • -7
    • +7
    ./Modes/InletPressureCheck.c
    • -4
    • +5
    ./Modes/InletPressureCheck.h
    • -0
    • +1
    ./Modes/ModePreGenPermeate.c
  4. … 1 more file in changeset.
Tuesday 19 Aug
10:24 am

Raghu Kallala

Addressed review comments to remove unwanted code lines and handled state assignment.

Options
    • -4
    • +1
    ./Modes/InletPressureCheck.c
    • -1
    • +0
    ./Modes/InletPressureCheck.h
    • -0
    • +1
    ./Modes/ModePreGenPermeate.c
10:14 am

Raghu Kallala

declared result at the top of the scope for test functions

Options
    • -3
    • +6
    ./Controllers/ROPump.c
9:42 am

Michael Garthwaite

LDT-1242: updated permeate tank control to change based on low level.

Options
    • -6
    • +10
    ./Controllers/PermeateTank.c
    • -3
    • +4
    ./Drivers/PressureSensor.c
Thursday 14 Aug
1:09 pm

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./FPCommon.h
1:08 pm

Michael Garthwaite

LDT-566: reverted publishing change for fine tuning.

Options
    • -5
    • +5
    ./Controllers/ROPump.c
1:07 pm

Michael Garthwaite

LDT-566: fixed RO Pump publishing to no longer have debug data for PI control

Options
    • -5
    • +5
    ./Controllers/ROPump.c
11:15 am

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./FPCommon.h
11:11 am

Michael Garthwaite

LDT-2003: 1st stage of flow control. still wip. moved event from bad crc error to all faults.

Options
    • -18
    • +35
    ./Controllers/ROPump.c
    • -2
    • +6
    ./Services/AlarmMgmtFP.c
    • -4
    • +1
    ./Services/SystemCommFP.c
Wednesday 13 Aug
3:44 pm

Dara Navaei

Bamboo Commit: Updated FPCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./FPCommon.h
3:41 pm

Michael Garthwaite

LDT-566: increased permeate flush timer to 5 minutes to support conductivity testing.

Options
    • -1
    • +1
    ./Modes/FlushPermeate.c
3:00 pm

Raghu Kallala

Removed commented code lines

Options
    • -2
    • +0
    ./Controllers/ROPump.c
1:46 pm

Raghu Kallala

Addressed review comments and modified the override behavior as discussed.

Options
    • -174
    • +161
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Controllers/ROPump.h
    • -1
    • +1
    ./Drivers/FluidPump.h