td-firmware

Clone Tools

Stats

Commits this week: 57
Total Committers: 13
Last Commit: 24 Feb
Commits this week: 57

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 24 Feb
8:45 pm

Vendor - TEL - Sameer Poyil

Merge branch LDT-1903-air-trap-level-control---td---0 into develop

Options
    • -0
    • +2
    /firmware/App/Controllers/AirPump.c
7:56 pm

Sean Nash

7:55 pm

Vendor - TEL - Sameer Poyil

LDT-1903 Air Trap updates

Options
    • -0
    • +2
    /firmware/App/Controllers/AirPump.c
    • -0
    • +2
    /firmware/App/Controllers/AirPump.h
    • -6
    • +2
    /firmware/App/Controllers/AirTrap.c
    • -4
    • +4
    /firmware/App/Drivers/GLXferPump.c
2:47 pm

Sean Nash

1:27 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/TDCommon.h
1:26 pm

Vendor - TEL - Sameer Poyil

Merge branch 'develop' of bitbucket.org:diality-cloud/td-firmware into develop

Options
1:26 pm

Vendor - TEL - Sameer Poyil

Merge branch LDT-1903-air-trap-level-control---td---0 into develop

Options
1:24 pm

Vendor - TEL - Sameer Poyil

LDT-1903 adjusting lowering delay timer after fill complete

Options
    • -0
    • +2
    /firmware/App/Controllers/AirTrap.c
10:38 am

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/TDCommon.h
10:35 am

Vendor - TEL - Sameer Poyil

Merge branch LDT-1903-air-trap-level-control---td---0 into develop

Options
    • -13
    • +12
    /firmware/App/Controllers/AirPump.c
10:29 am

Vendor - TEL - Sameer Poyil

LDT-1903 addressed the review comments

Options
    • -3
    • +4
    /firmware/App/Drivers/GLXferPump.c
10:24 am

Vendor - TEL - Sameer Poyil

LDT-1903 addressed review comments

Options
    • -1
    • +1
    /firmware/App/Drivers/GLXferPump.c
10:22 am

Vendor - TEL - Sameer Poyil

LDT-1903 addressed the review comments

Options
    • -13
    • +12
    /firmware/App/Controllers/AirPump.c
    • -1
    • +1
    /firmware/App/Controllers/AirPump.h
10:01 am

Sean Nash

I don't see why we need the extra precision here. I suspect a 64-bit division is expensive (s/w library implementation instead of co-processor) so I don't like to use doubles unless it is truly nec...

I don't see why we need the extra precision here. I suspect a 64-bit division is expensive (s/w library implementation instead of co-processor) so I don't like to use doubles unless it is truly necessary.

9:59 am

Sean Nash

Add blank line before return.

Add blank line before return.

9:58 am

Sean Nash

0.0F

0.0F

9:58 am

Sean Nash

Use "F64" macro instead of double.

Use "F64" macro instead of double.

9:48 am

Vendor - TEL - Sameer Poyil

Yes , right now its void , so that's why i didn't change that . I will push new code

Yes , right now its void , so that's why i didn't change that . I will push new code

9:43 am

Vendor - TEL - Sameer Poyil

LDT-2004 Airpump RPM implementation

Options
    • -1
    • +15
    /firmware/App/Drivers/GLXferPump.c
9:30 am

Sean Nash

setAirPumpState could return a BOOL (FALSE if range check fails or state invalid) that you can set result to.

setAirPumpState could return a BOOL (FALSE if range check fails or state invalid) that you can set result to.

9:26 am

Vendor - TEL - Sameer Poyil

Merge branch LDT-1903-air-trap-level-control---td---0 into develop

Options
    • -2
    • +11
    /firmware/App/Controllers/AirPump.c
    • -1
    • +5
    /firmware/App/Drivers/GLXferPump.h
    • -0
    • +12
    /firmware/App/Services/FpgaTD.c
    • -0
    • +1
    /firmware/App/Services/FpgaTD.h
9:24 am

Sean Nash

Inputs is none or FPGA.

Inputs is none or FPGA.

9:07 am

Raghu Kallala

LDT-473 added place holder for param range checks with institutional records

Options
    • -0
    • +3
    /firmware/App/Services/TxParams.c
8:15 am

Vendor - TEL - Sameer Poyil

done

done

8:14 am

Vendor - TEL - Sameer Poyil

done , but I need to check it here

done , but I need to check it here

8:14 am

Vendor - TEL - Sameer Poyil

done

done

8:09 am

Vendor - TEL - Sameer Poyil

LDT-1903 Adressed the review comments

Options
    • -4
    • +4
    /firmware/App/Controllers/AirTrap.c
    • -6
    • +7
    /firmware/App/Drivers/GLXferPump.c
    • -0
    • +1
    /firmware/App/Drivers/GLXferPump.h
Monday 23 Feb
6:18 pm

Vendor - TEL - Sameer Poyil

Yes, without checking the changes in this file, I pushed it. It is OK when I merge the code. There is no option to correct since my local branch shows 28.its auto generated and it will take next ve...

Yes, without checking the changes in this file, I pushed it. It is OK when I merge the code. There is no option to correct since my local branch shows 28.its auto generated and it will take next version during the merge with staging.

6:14 pm

Vendor - TEL - Sameer Poyil

LDT-1903 Adressed the new changes for air pump PWM duty cycle for lowering and review comments

Options
    • -4
    • +3
    /firmware/App/Controllers/AirPump.c
    • -2
    • +0
    /firmware/App/Drivers/GLXferPump.c
    • -0
    • +2
    /firmware/App/Drivers/GLXferPump.h
6:08 pm

Vendor - TEL - Sameer Poyil

If I don't check it here, Dialin get a true for even invalid range. I need to pass the result immediately to user so that user can take the action.

If I don't check it here, Dialin get a true for even invalid range. I need to pass the result immediately to user so that user can take the action.