td-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-4072: Address code review comments

    • -50
    • +91
    /firmware/App/Drivers/BatteryDriver.c
    • -12
    • +5
    /firmware/App/Drivers/BatteryDriver.h
    • -0
    • +356
    /firmware/App/Monitors/Battery.c
    • -0
    • +92
    /firmware/App/Monitors/Battery.h
    • -493
    • +0
    /firmware/App/Monitors/BatteryMonitor.c
    • -78
    • +0
    /firmware/App/Monitors/BatteryMonitor.h
LDT-3505: Minor

    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
LDT-3505: Activated Safety Shutdown

    • -0
    • +1
    /firmware/App/Controllers/SyringePump.c
LDT-3505: Updated doxygen comments

    • -33
    • +43
    /firmware/App/Controllers/SyringePump.c
LDT-3505: Code clean up and documentation

    • -150
    • +238
    /firmware/App/Controllers/SyringePump.c
    • -20
    • +18
    /firmware/App/Controllers/SyringePump.h
LDT-1886: Update doxygen stuff

Yes Noe said to replace with new register

Yes Noe said to replace with new register

Updated

Updated

Sure

Sure

LDT-4033-patient-vitals-fw-implementation

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

Why was this function header changed? I think it was correct before.

Why was this function header changed? I think it was correct before.

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

If we don't set this pwm time anymore, we don't need this. Please make sure we really don't need this anymore though.

If we don't set this pwm time anymore, we don't need this. Please make sure we really don't need this anymore though.

I don't think these definitions need to be public. Some of these should probably be inside the FpgaTD.c and some should probably be inside your driver's .c file.

I don't think these definitions need to be public. Some of these should probably be inside the FpgaTD.c and some should probably be inside your driver's .c file.

create a local BOOL result and use a ternary to assign FALSE or TRUE explicitly.

create a local BOOL result and use a ternary to assign FALSE or TRUE explicitly.

Did Noe delete the H12 period register? According to this structure, syrPumpDACControl is 2 bytes (U16), so next register should be 42 (40+2). So why do you have 41? Something is out of sync with H...

Did Noe delete the H12 period register?
According to this structure, syrPumpDACControl is 2 bytes (U16), so next register should be 42 (40+2). So why do you have 41? Something is out of sync with HDD here. Please align with the HDD.

What is in registers 378..383? We need to add those registers or incoming data won't overlay properly into structure.

What is in registers 378..383? We need to add those registers or incoming data won't overlay properly into structure.

LDT-3259 updated the linker file

Merge branch 'staging' into LDT-3259-software-update---td-firmware

LDT-3259 updated the pressures function in release build

Call the init for the battery driver here.

Call the init for the battery driver here.

INVALID_BATTERY

INVALID_BATTERY

Remove repeating entries.

Remove repeating entries.

remove extra blank line.

remove extra blank line.

Remove this comment.

Remove this comment.

Remove blank line.

Remove blank line.

initialize all of these in init function.

initialize all of these in init function.