td-firmware

Clone Tools

Stats

Commits this week: 32
Total Committers: 18
Last Commit: 10:53
Commits this week: 32

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 21 Jul
8:48 pm

suresh

LDT:4049 Addressed review comments

Options
    • -317
    • +11
    /firmware/App/Modes/ModeStandby.c
6:18 pm

Sean Nash

Should we handle blood sitting timer before publish? Are we publishing anything re: blood sitting?

Should we handle blood sitting timer before publish? Are we publishing anything re: blood sitting?

6:07 pm

Sean Nash

Add TODO to these comments.

Add TODO to these comments.

5:45 pm

Sean Nash

I think ( setTxDur - preStop ) should be changed to ( preStop ). Also, I think preStop should be renamed to hepDurMin.

I think ( setTxDur - preStop ) should be changed to ( preStop ).
Also, I think preStop should be renamed to hepDurMin.

5:14 pm

Sean Nash

Add comments to right.

Add comments to right.

5:13 pm

Sean Nash

2 blank lines before and after.

2 blank lines before and after.

5:09 pm

Sean Nash

Move declarations into this if scope.

Move declarations into this if scope.

5:08 pm

Sean Nash

Remove blank line.

Remove blank line.

5:07 pm

Sean Nash

Remove (void)

Remove (void)

5:06 pm

Sean Nash

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

4:55 pm

Sean Nash

Change INPROGRESS to OPEN (because you're going to remove INPROGRESS).

Change INPROGRESS to OPEN (because you're going to remove INPROGRESS).

4:32 pm

Sean Nash

You can do this sendMessage just once after else.

You can do this sendMessage just once after else.

3:57 pm

suresh

LDT:4063- Addressed review comments

Options
    • -0
    • +4
    /firmware/App/Modes/ModeInitPOST.c
    • -32
    • +44
    /firmware/App/Modes/OperationModes.c
    • -8
    • +10
    /firmware/App/Monitors/Buttons.c
    • -1
    • +3
    /firmware/App/Services/Messaging.c
    • -7
    • +0
    /firmware/App/Services/Messaging.h
2:13 pm

Sean Nash

Should this be the "Load Syringe" alarm that you just added? Also, does this alarm show the user how much heparin to load into the syringe? I wasn't expecting this to be an alarm.

Should this be the "Load Syringe" alarm that you just added?
Also, does this alarm show the user how much heparin to load into the syringe? I wasn't expecting this to be an alarm.

2:10 pm

Sean Nash

Can we remote this TODO comment?

Can we remote this TODO comment?

2:09 pm

Sean Nash

Remove blank line.

Remove blank line.

2:08 pm

Sean Nash

We should go to dry self test state. Why did this change to Rx state?

We should go to dry self test state. Why did this change to Rx state?

2:07 pm

Sean Nash

Comment - should be "install" not "instll".

Comment - should be "install" not "instll".

1:59 pm

Vendor - TEL - Vijay Pamula

LDT-4009:Merge latest staging adnd Updated Isouf

Options
    • -6
    • +11
    /firmware/App/Modes/ModeTreatment.c
    • -3
    • +5
    /firmware/App/Modes/ModeTreatment.h
    • -4
    • +129
    /firmware/App/Modes/StateTxIsolatedUF.c
    • -0
    • +2
    /firmware/App/Modes/StateTxIsolatedUF.h
    • -0
    • +1
    /firmware/App/Services/Messaging.c
1:19 pm

Vendor - TEL - Vijay Pamula

1:14 pm

Vendor - TEL - Vijay Pamula

LDT-4029:Merge latest staging and updated heparin setup state

Options
    • -0
    • +13
    /firmware/App/Controllers/SyringePump.c
    • -0
    • +1
    /firmware/App/Controllers/SyringePump.h
    • -0
    • +4
    /firmware/App/Modes/ModePreTreat.c
    • -56
    • +106
    /firmware/App/Modes/StatePreTxHeparinSetup.c
10:35 am

Vendor - TEL - Arpita Srivastava

add a space before and after 0

add a space before and after 0

10:35 am

Vendor - TEL - Arpita Srivastava

add a blank line above

add a blank line above

10:33 am

Vendor - TEL - Arpita Srivastava

add a blank line above

add a blank line above

10:27 am

Vendor - TEL - Arpita Srivastava

minor spell issue : change responceStatus to responseStatus

minor spell issue : change responceStatus to responseStatus

10:26 am

Vendor - TEL - Arpita Srivastava

add offRequestAwaitingUserConfirmation and offRequestPendingTimer to outputs

add offRequestAwaitingUserConfirmation and offRequestPendingTimer to outputs

10:24 am

Vendor - TEL - Arpita Srivastava

should we move the initialization in the init function?

should we move the initialization in the init function?

10:19 am

Vendor - TEL - Arpita Srivastava

please break this line into two lines

please break this line into two lines

10:19 am

Vendor - TEL - Arpita Srivastava

Vendor - TEL - Arpita Srivastava please add a space before and after in sizeof(U32) in [sizeof(U32)]

Vendor - TEL - Arpita Srivastava
please add a space before and after in sizeof(U32) in [sizeof(U32)]

10:16 am

Vendor - TEL - Arpita Srivastava

please add a space before and after 0 in payload[0]

please add a space before and after 0 in payload[0]