td-firmware

Clone Tools

Stats

Commits this week: 56
Total Committers: 17
Last Commit: 12 Aug
Commits this week: 56

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Aug
4:33 pm

Vendor - TEL - Vijay Pamula

LDT-4029:Merge latest staging

Options
    • -2
    • +2
    /firmware/App/Controllers/SyringePump.h
    • -21
    • +182
    /firmware/App/Modes/ModePreTreat.c
    • -8
    • +12
    /firmware/App/Modes/ModePreTreat.h
    • -1
    • +1
    /firmware/App/Modes/StatePreTxHeparinSetup.c
    • -2
    • +8
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -4
    • +49
    /firmware/App/Services/AlarmMgmtTD.c
    • -2
    • +3
    /firmware/App/Services/TxParams.c
4:03 pm

Vendor - TEL - Varshini Nagabooshanam

Add ons

Options
    • -31
    • +59
    /firmware/App/Modes/ModeStandby.c
3:57 pm

Sean Nash

Remove blank line.

Remove blank line.

3:53 pm

Sean Nash

Still there.

Still there.

3:53 pm

Sean Nash

Remove if not needed.

Remove if not needed.

3:52 pm

Sean Nash

Why commented out? If not needed, delete.

Why commented out? If not needed, delete.

3:00 pm

Sean Nash

Use if/else or ternary to set result to TRUE or FALSE explicitly.

Use if/else or ternary to set result to TRUE or FALSE explicitly.

3:00 pm

suresh

Added handlers for the states

Options
    • -4
    • +0
    /firmware/App/Controllers/BloodFlow.c
    • -25
    • +84
    /firmware/App/Modes/ModePostTreat.c
    • -0
    • +2
    /firmware/App/Modes/ModePostTreat.h
    • -21
    • +123
    /firmware/App/Services/Messaging.c
    • -2
    • +3
    /firmware/App/Services/Messaging.h
2:59 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:58 pm

Sean Nash

Fix indent for break. Add comment before break "// unhandled command - do nothing.

Fix indent for break. Add comment before break "// unhandled command - do nothing.

2:58 pm

Sean Nash

Fix indent for break. Add comment before break "// unhandled position - do nothing.

Fix indent for break. Add comment before break "// unhandled position - do nothing.

2:57 pm

Sean Nash

Do we need this code? Can we delete it?

Do we need this code? Can we delete it?

2:53 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:51 pm

Sean Nash

Change these comments (H1 and H19 home arrays) to something like "Command list for H1 homing function."

Change these comments (H1 and H19 home arrays) to something like "Command list for H1 homing function."

2:50 pm

Sean Nash

Change comment to "Command list for pinch valve position change function."

Change comment to "Command list for pinch valve position change function."

2:49 pm

Sean Nash

Add a space before &

Add a space before &

2:31 pm

Vendor - TEL - Vijay Pamula

LDT-4029:Updated heparin setup state

Options
    • -2
    • +2
    /firmware/App/Modes/StatePreTxHeparinSetup.c
2:25 pm

Vendor - TEL - Vijay Pamula

LDT-4029:Updated Heparin setup state

Options
    • -0
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -5
    • +13
    /firmware/App/Modes/StatePreTxHeparinSetup.c
10:26 am

Sean Nash

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

10:25 am

Sean Nash

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

10:21 am

Sean Nash

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

10:11 am

Sean Nash

Is this still necessary? Comment out before merging to staging.

Is this still necessary? Comment out before merging to staging.

10:10 am

Sean Nash

Why are registers being repeated? Sync w/ latest HDD.

Why are registers being repeated? Sync w/ latest HDD.

10:08 am

Sean Nash

Can we remove this commented out line of code?

Can we remove this commented out line of code?

10:07 am

Sean Nash

Why is this commented out?

Why is this commented out?

10:05 am

Sean Nash

Why is state transition and publish removed?

Why is state transition and publish removed?

9:47 am

Vendor - TEL - Arpita Srivastava

Please address the commented code.

Please address the commented code.

9:46 am

Vendor - TEL - Arpita Srivastava

Should we remove the commented code?

Should we remove the commented code?

9:41 am

Vendor - TEL - Arpita Srivastava

We should manage the commented-out code.

We should manage the commented-out code.

9:39 am

Vendor - TEL - Arpita Srivastava

break this line

break this line