Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT:4063 Addressed review comments

  1. … 4 more files in changeset.
LDT-4009: Merge latest staging

  1. … 6 more files in changeset.
LDT-4040: Address CR comments and update rinseback realted code

  1. … 5 more files in changeset.
LDT-4611: HDF state machine implementation plus calls to controller

  1. … 5 more files in changeset.
LDT:4049 Addressed review comments

Merge branch 'LDT-4003-hdf-fw-implementation-4-4' into LDT-4611-hdf-fw-implementation-5-4

  1. … 2 more files in changeset.
LDT-4029: Merge Latest staging

  1. … 1 more file in changeset.
LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
Merge latest staging into LDT-4049 Standby implementation

  1. … 2 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 6 more files in changeset.
I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmatio...

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

LDT:4049-Addressed review comments

LDT-4029: Addressed review comments

  1. … 1 more file in changeset.
171

171

Is this too early to tell DD to start? Ask Vinay.

Is this too early to tell DD to start? Ask Vinay.

Initialize post treatment too.

Initialize post treatment too.

Delete this. No treatment params mode in Leahi.

Delete this. No treatment params mode in Leahi.

Add blank line between declarations and code.

Add blank line between declarations and code.

I would keep this stuff commented out until disinfection is implemented.

I would keep this stuff commented out until disinfection is implemented.

Door already not required. Remove.

Door already not required. Remove.

break into 2 lines.

break into 2 lines.

Let's comment remaining states for now.

Let's comment remaining states for now.

Remove this line. There is no syringe detection.

Remove this line. There is no syringe detection.

Door is probably not required to be closed in standby. Change to FALSE.

Door is probably not required to be closed in standby. Change to FALSE.

Let's remove this for now.

Let's remove this for now.

Service record not yet available. Comment out with TODO

Service record not yet available. Comment out with TODO

INVALID_REQUEST_FORMAT

INVALID_REQUEST_FORMAT