Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-4040: Address CR comments and update rinseback realted code

LDT-4611: HDF state machine implementation plus calls to controller

    • -23
    • +87
    ./Controllers/HemoDiaFiltration.c
    • -0
    • +540
    ./Modes/StateTxHDF.c
    • -0
    • +55
    ./Modes/StateTxHDF.h
    • -0
    • +2
    ./Services/StateServices/TubeSetInstall.c
LDT:4049 Addressed review comments

Merge branch 'LDT-4003-hdf-fw-implementation-4-4' into LDT-4611-hdf-fw-implementation-5-4

LDT-4029: Merge Latest staging

LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
Merge latest staging into LDT-4049 Standby implementation

  1. … 1 more file in changeset.
Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Changes

Fixes

Fixes and changes

    • -0
    • +1
    ./Services/StateServices/TubeSetInstall.c
Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -2
    • +2
    ./Services/StateServices/TubeSetInstall.c
    • -2
    • +2
    ./Services/StateServices/TubeSetInstall.h
Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Added Torque

Added Torque

LDT-4149: more changes.

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmatio...

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

LDT:4049-Addressed review comments

LDT-4029: Addressed review comments

    • -28
    • +42
    ./Modes/StatePreTxHeparinSetup.c
171

171

Is this too early to tell DD to start? Ask Vinay.

Is this too early to tell DD to start? Ask Vinay.

Initialize post treatment too.

Initialize post treatment too.

Delete this. No treatment params mode in Leahi.

Delete this. No treatment params mode in Leahi.

Add blank line between declarations and code.

Add blank line between declarations and code.

Fixes

I would keep this stuff commented out until disinfection is implemented.

I would keep this stuff commented out until disinfection is implemented.