td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 23
Total Committers: 18
Last Commit: 23 Jul
Commits this week: 23

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 23 Jul
10:39 am

Sean Nash

LDT-4149: More changes.

Options
    • -3
    • +0
    ./Controllers/Valves.c
    • -12
    • +0
    ./Controllers/Valves.h
    • -56
    • +48
    ./Drivers/PinchValve.c
    • -0
    • +10
    ./Drivers/PinchValve.h
10:35 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

10:34 am

Vendor - TEL - Arpita Srivastava

Add @Alarms

Add @Alarms

10:33 am

Vendor - TEL - Arpita Srivastava

Add @Alarms

Add @Alarms

10:31 am

Vendor - TEL - Arpita Srivastava

fluidType is an input

fluidType is an input

10:30 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

10:27 am

Vendor - TEL - Arpita Srivastava

Initialization is missing in the init function for variables from line 72 to 77.

Initialization is missing in the init function for variables from line 72 to 77.

10:26 am

Vendor - TEL - Arpita Srivastava

Initialize in init.

Initialize in init.

10:25 am

Vendor - TEL - Arpita Srivastava

Initialize in init. Check SyringPump.c for reference.

Initialize in init. Check SyringPump.c for reference.

9:53 am

Vendor - TEL - Varshini Nagabooshanam

Changes

Options
    • -20
    • +20
    ./Controllers/Valves.c
    • -1
    • +1
    ./Controllers/Valves.h
    • -46
    • +116
    ./Drivers/PinchValve.c
    • -1
    • +10
    ./Drivers/PinchValve.h
    • -501
    • +0
    ./Drivers/RotaryValve.c
    • -70
    • +0
    ./Drivers/RotaryValve.h
    • -1
    • +0
    ./Modes/ModeFault.c
    • -0
    • +1
    ./Modes/ModeStandby.c
    • -1
    • +1
    ./Services/AlarmMgmtTD.c
    • -4
    • +3
    ./Services/Messaging.c
    • -1
    • +1
    ./Services/SystemCommTD.c
    • -2
    • +2
    ./TDCommon.h
    • -1
    • +1
    ./Tasks/TaskGeneral.c
9:50 am

Vendor - TEL - Arpita Srivastava

please add a TODO or remove commented code.

please add a TODO or remove commented code.

9:50 am

Vendor - TEL - Arpita Srivastava

please add a TODO or remove commented code.

please add a TODO or remove commented code.

9:49 am

Vendor - TEL - Arpita Srivastava

add resumeTreatmentAlarmResponseRequest to output

add resumeTreatmentAlarmResponseRequest to output

9:47 am

Vendor - TEL - Arpita Srivastava

Update input - output list.

Update input - output list.

9:41 am

Vendor - TEL - Arpita Srivastava

Add presUFRateMlMin to outputs

Add presUFRateMlMin to outputs

9:39 am

Vendor - TEL - Arpita Srivastava

recirculateToBloodPrimeRequest is output.

recirculateToBloodPrimeRequest is output.

9:34 am

Vendor - TEL - Arpita Srivastava

Add initialization for rinsebackToRecircRequest and recirculateToBloodPrimeRequest

Add initialization for rinsebackToRecircRequest and recirculateToBloodPrimeRequest

9:07 am

Sean Nash

So then no need to initialize it here too. Remove " = FALSE".

So then no need to initialize it here too. Remove " = FALSE".

9:06 am

Sean Nash

9:03 am

Sean Nash

Wednesday 22 Jul
9:28 pm

Vendor - TEL - Suresh Dharnala

I agree but it is already in the init function.

I agree but it is already in the init function.

1:19 pm

Vendor - TEL - Praneeth Bunne

LDT-4040: Address CR comments

Options
    • -2
    • +2
    ./Modes/ModeTreatment.h
    • -9
    • +9
    ./Modes/StateTxRinseback.c
11:32 am

Sean Nash

Swap order of == for these 2 if statements - put constant on left side.

Swap order of == for these 2 if statements - put constant on left side.

11:19 am

Sean Nash

Why?

Why?

11:16 am

Sean Nash

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

11:14 am

Sean Nash

Use ternary operator to explicitly set to TRUE or FALSE.

Use ternary operator to explicitly set to TRUE or FALSE.

10:53 am

suresh

LDT:4049- addressed review comments

Options
    • -2
    • +0
    ./Drivers/RotaryValve.h
    • -5
    • +7
    ./Modes/ModeInitPOST.c
    • -1
    • +1
    ./Modes/ModeInitPOST.h
    • -11
    • +13
    ./Modes/ModeStandby.c
    • -1
    • +3
    ./Services/DDInterface.c
    • -1
    • +1
    ./Services/DDInterface.h
    • -8
    • +0
    ./Services/Messaging.h
9:31 am

Sean Nash

Our TODO comments are all CAPs.

Our TODO comments are all CAPs.

9:25 am

Sean Nash

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

9:21 am

Sean Nash

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.