td-firmware / firmware

App

Clone Tools

Stats

Commits this week: 65
Total Committers: 17
Last Commit: 16:19
Commits this week: 65

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 13 Aug
6:54 pm

suresh

LDT-4050:added posttx states

Options
    • -0
    • +3
    ./Modes/ModePostTreat.h
    • -3
    • +0
    ./Services/Messaging.h
3:25 pm

Vendor - TEL - Arpita Srivastava

Update inputs and outputs

Update inputs and outputs

3:19 pm

Vendor - TEL - Arpita Srivastava

revert back the comment alignment change

revert back the comment alignment change

3:16 pm

Vendor - TEL - Arpita Srivastava

fix indentation

fix indentation

3:15 pm

Vendor - TEL - Arpita Srivastava

add @param

add @param

3:15 pm

Vendor - TEL - Arpita Srivastava

add @param

add @param

3:14 pm

Vendor - TEL - Arpita Srivastava

add @param

add @param

3:13 pm

Vendor - TEL - Arpita Srivastava

add @param

add @param

3:07 pm

Vendor - TEL - Arpita Srivastava

Change H19 to H1?

Change H19 to H1?

3:06 pm

Vendor - TEL - Arpita Srivastava

Should it be H1?

Should it be H1?

3:04 pm

Vendor - TEL - Arpita Srivastava

Input is none fpgaActuatorSetPoints should be ouput of all the set functions.

Input is none
fpgaActuatorSetPoints should be ouput of all the set functions.

2:57 pm

Vendor - TEL - Arpita Srivastava

use ternary operator

use ternary operator

2:57 pm

Vendor - TEL - Arpita Srivastava

use ternary operator

use ternary operator

2:56 pm

Vendor - TEL - Arpita Srivastava

use ternary operator

use ternary operator

2:51 pm

Vendor - TEL - Arpita Srivastava

break this line: bring everything after & to the next line.

break this line: bring everything after & to the next line.

2:49 pm

Vendor - TEL - Arpita Srivastava

Use the Ternary operator format ? : to assign TRUE or FALSE

Use the Ternary operator format ? : to assign TRUE or FALSE

2:48 pm

Vendor - TEL - Arpita Srivastava

Use the Ternary operator format ? : to assign TRUE or FALSE

Use the Ternary operator format ? : to assign TRUE or FALSE

2:48 pm

Vendor - TEL - Arpita Srivastava

Use the Ternary operator format ? : to assign TRUE or FALSE

Use the Ternary operator format ? : to assign TRUE or FALSE

2:45 pm

Sean Nash

2:38 pm

Vendor - TEL - Arpita Srivastava

Move fpgaCommandValue to input. Output is none

Move fpgaCommandValue to input.
Output is none

2:34 pm

Vendor - TEL - Arpita Srivastava

Remove valve

Remove valve

2:32 pm

Vendor - TEL - Arpita Srivastava

General Comment: If a variable is a param, please remove it from the inputs section of the doxygen header of all the functions.

General Comment:
If a variable is a param, please remove it from the inputs section of the doxygen header of all the functions.

2:32 pm

Sean Nash

If you're not using it, remove it.

If you're not using it, remove it.

2:30 pm

Vendor - TEL - Arpita Srivastava

Input and Output are none.

Input and Output are none.

2:28 pm

Sean Nash

nextState in state handling functions should always be initialized to the state being handled (assume we are not transitioning until criteria is met to transition).

nextState in state handling functions should always be initialized to the state being handled (assume we are not transitioning until criteria is met to transition).

2:27 pm

Vendor - TEL - Arpita Srivastava

input is none

input is none

2:26 pm

Vendor - TEL - Arpita Srivastava

Inputs is none

Inputs is none

2:26 pm

Vendor - TEL - Arpita Srivastava

Outputs: Remove enableResetValue. Add pendingValveHomeRequest and pendingValvePositionRequest.

Outputs:
Remove enableResetValue.
Add pendingValveHomeRequest and pendingValvePositionRequest.

2:26 pm

Sean Nash

I see a lot of people doing this to avoid a compiler warning (due to non-use of the given parameter). I don't think we should have to do weird things like this. As we get closer to s/w release, we ...

I see a lot of people doing this to avoid a compiler warning (due to non-use of the given parameter).
I don't think we should have to do weird things like this. As we get closer to s/w release, we can consider removing the function if it's still not doing anything.

2:23 pm

Sean Nash

I consider constants as similar to a #define and prefer to put them in the definitions section.

I consider constants as similar to a #define and prefer to put them in the definitions section.