What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

Why increment the number when you didn't add a new sensor?

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

LEVEL_OFFSET?

· /leahi_dialin/common/dd_defs.py

(-2, +2)

| History

| Source

| Diff

]]> Wed, 08 Apr 2026 11:26:38 -0700 Zoltan Miskolci https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3824-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3824-1 Zoltan Miskolci Closed LEAHI-DIALIN-LDT-3824-1 ]]> Wed, 08 Apr 2026 10:01:06 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3824-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3824-1 Michael Garthwaite and Raghu Kallala finished reviewing LEAHI-DIALIN-LDT-3824-1 LEAHI-DIALIN-LDT-3824_[Leahi-TestCommon] Enhance state machine ]]> Wed, 08 Apr 2026 09:48:10 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3824-1/#c28254 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3824-1/#c28254 Raghu Kallala commented on LEAHI-DIALIN-LDT-3824-1

Typo, response

Typo, response

Fix the header

· /leahi_dialin/common/dd_defs.py	(-8, +9)	| History	| Source	| Diff
· /leahi_dialin/common/fp_defs_proxy.py	(-1, +1)	| History	| Source	| Diff

]]> Thu, 02 Apr 2026 11:13:12 -0700 Zoltan Miskolci https://devapps.diality.us/changelog/leahi-dialin?cs=c6b28ca8a6aae3f70458f05b5bf445069e2fe457 https://devapps.diality.us/changelog/leahi-dialin?cs=c6b28ca8a6aae3f70458f05b5bf445069e2fe457 Zoltan Miskolci committed c6b28ca on branch LDT-1195-dd-is-balancing-chamber-switching, LDT-3352-dd---revisit-d3-level-control-l and 16 more in leahi-dialin enum updates

· /leahi_dialin/common/dd_defs.py	(-19, +197)	| History	| Source	| Diff
· /leahi_dialin/common/dd_defs_proxy.py	(-2, +19)	| History	| Source	| Diff
· /leahi_dialin/common/disp_defs.py	(-0, +84)	| History	| Source
· /leahi_dialin/common/disp_defs_proxy.py	(-0, +26)	| History	| Source
· /leahi_dialin/common/fp_defs.py	(-1, +106)	| History	| Source	| Diff
· /leahi_dialin/common/fp_defs_proxy.py	(-0, +14)	| History	| Source	| Diff
· /leahi_dialin/common/msg_ids.py	(-0, +3)	| History	| Source	| Diff
· /leahi_dialin/common/td_defs.py	(-106, +560)	| History	| Source	| Diff
· /leahi_dialin/common/td_defs_proxy.py	(-38, +72)	| History	| Source	| Diff
· /leahi_dialin/fp/filtration_purification.py	(-7, +6)	| History	| Source	| Diff
· /leahi_dialin/td/modules/ejector.py	(-1, +1)	| History	| Source	| Diff

]]> Tue, 31 Mar 2026 10:32:37 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3824-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3824-1 Dara Navaei started review LEAHI-DIALIN-LDT-3824-1 ]]> Mon, 30 Mar 2026 09:39:06 -0700 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1 Sean Nash finished reviewing LEAHI-DIALIN-LDT-2655-1 LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module ]]> Mon, 16 Mar 2026 10:04:25 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c28052 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2655-1/#c28052 Michael Garthwaite replied to Sean Nash in LEAHI-DIALIN-LDT-2655-1

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).