Fisheye on dd-firmware/firmware/App/Services/Messaging.c

Fisheye on dd-firmware/firmware/App/Services/Messaging.c https://devapps.diality.us/changelog/~br%3DLDT-3735-non-volatile-memory/dd-firmware/firmware/App/Services/Messaging.c Recent activity in "dd-firmware" under directory /firmware/App/Services/Messaging.c LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers resumed Fri, 24 Apr 2026 22:17:00 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani resumed reviewing LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> dd-firmware (LDT-3735-non-volatile-memory): LDT-3735: Added Alarms and software faults for NVM Fri, 24 Apr 2026 16:22:26 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/changelog/dd-firmware?cs=0face6417892ea9de28d146bf88d44a9f30cf2a4 https://devapps.diality.us/changelog/dd-firmware?cs=0face6417892ea9de28d146bf88d44a9f30cf2a4 Vendor - TEL - Arpita Srivastava committed 0face64 on branch LDT-3735-non-volatile-memory in dd-firmware LDT-3735: Added Alarms and software faults for NVM

· /firmware/App/Services/AlarmMgmtSWFaults.h (-0, +8) | History | Source | Diff

· /firmware/App/Services/Messaging.c (-0, +5) | History | Source | Diff

· /firmware/App/Services/NVMgmtDD.c (-3, +4) | History | Source | Diff

· /firmware/App/Services/NVMsgQ.c (-18, +72) | History | Source | Diff

· /firmware/App/Services/NVMsgQ.h (-3, +11) | History | Source | Diff

· /firmware/App/Services/NVRecordsDD.c (-11, +16) | History | Source | Diff

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: reviewers joined LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conduc... Thu, 23 Apr 2026 14:59:17 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Vinayakam Mani joined LEAHI-DD-FIRMWARE-LDT-3978-1 LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid ]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "instead of 0, we can use the level Enum 'LVL_ST..." Thu, 23 Apr 2026 14:56:16 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28636 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "lower? and change the D98 level sensor comment ..." Thu, 23 Apr 2026 14:49:10 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28635 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

lower? and change the D98 level sensor comment as well.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Remove empty line" Thu, 23 Apr 2026 14:47:11 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28634 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space before LVL_STATE_LOW" Thu, 23 Apr 2026 14:45:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28633 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space before LVL_STATE_LOW

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "space inside array index." Thu, 23 Apr 2026 14:43:35 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28632 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

space inside array index.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Space inside parenthesis." Thu, 23 Apr 2026 14:41:03 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28631 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Space inside parenthesis.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Change this to LEVEL_T enum." Thu, 23 Apr 2026 14:39:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28630 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Change this to LEVEL_T enum.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: comment by Vinayakam Mani "Is this macro still being used? if not, delete ..." Thu, 23 Apr 2026 14:38:55 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1/#c28629 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3978-1

Is this macro still being used? if not, delete it.

]]> LEAHI-DD-FIRMWARE-LDT-3978-1: started by Dara Navaei Thu, 23 Apr 2026 07:47:26 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3978-1 ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: closed by Raghu Kallala Wed, 22 Apr 2026 10:41:20 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3749-2 ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: reviewers finished Wed, 22 Apr 2026 09:55:43 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: reviewers finished Tue, 21 Apr 2026 14:17:37 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> LEAHI-DD-FIRMWARE-LDT-3749-2: comment by Raghu Kallala "Updated" Tue, 21 Apr 2026 08:34:00 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28558 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28558 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3749-2

Updated

]]> LEAHI-DD-FIRMWARE-LDT-2004-9: closed by Vendor - TEL - Sameer Poyil Mon, 20 Apr 2026 08:17:53 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Vendor - TEL - Sameer Poyil Closed LEAHI-DD-FIRMWARE-LDT-2004-9 ]]> LEAHI-DD-FIRMWARE-LDT-3352-1: closed by Vinayakam Mani Fri, 17 Apr 2026 09:54:51 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Vinayakam Mani Closed LEAHI-DD-FIRMWARE-LDT-3352-1 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: reviewers finished Thu, 16 Apr 2026 23:17:41 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-2004-9 LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: started by Sean Nash Thu, 16 Apr 2026 23:13:27 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Sean Nash started review LEAHI-DD-FIRMWARE-LDT-2004-9 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: started by Vendor - TEL - Sameer Poyil Thu, 16 Apr 2026 16:23:22 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9 Vendor - TEL - Sameer Poyil started review LEAHI-DD-FIRMWARE-LDT-2004-9 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "Its static function and not used by external AP..." Thu, 16 Apr 2026 14:28:01 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28452 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28452 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-9

Its static function and not used by external API to pass the wrong id.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: closed by Michael Garthwaite Thu, 16 Apr 2026 08:15:43 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-3218-4 ]]> LEAHI-DD-FIRMWARE-LDT-2004-9: comment by Vendor - TEL - Sameer Poyil "0.0F is made by Sean." Wed, 15 Apr 2026 21:33:44 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28433 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28433 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-9

0.0F is made by Sean.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: reviewers finished Wed, 15 Apr 2026 17:31:50 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3218-4 LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed) ]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "by the end of S27 we will know if we need to ke..." Wed, 15 Apr 2026 16:12:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28431 Michael Garthwaite replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3218-4

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Vinayakam Mani "If this is the core change, can we introduce th..." Wed, 15 Apr 2026 15:34:19 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28426 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28426 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3218-4

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "nope. removed." Wed, 15 Apr 2026 09:52:57 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28375 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28375 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

nope. removed.

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed" Wed, 15 Apr 2026 09:52:50 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28374 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28374 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

]]> LEAHI-DD-FIRMWARE-LDT-3218-4: comment by Michael Garthwaite "fixed" Wed, 15 Apr 2026 09:52:35 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28373 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3218-4/#c28373 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3218-4

fixed

]]>