· /firmware/App/Modes/ModeFault.c	(-2, +5)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-57, +58)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModePostGenDialysate.c	(-2, +5)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-2, +5)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-14, +14)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-20, +22)	| History	| Source	| Diff

]]> Wed, 22 Apr 2026 10:41:20 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3749-2 ]]> Wed, 22 Apr 2026 09:55:43 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> Tue, 21 Apr 2026 14:17:37 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> Tue, 21 Apr 2026 08:34:00 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28558 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28558 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3749-2

Updated

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePostGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeService.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +2)	| History	| Source	| Diff

]]> Fri, 10 Apr 2026 11:38:33 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-1195-2 LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F) ]]> Fri, 10 Apr 2026 08:33:45 -0700 Raghu Kallala https://devapps.diality.us/changelog/dd-firmware?cs=8aa885b17330f096934f175d35912c3c95825039 https://devapps.diality.us/changelog/dd-firmware?cs=8aa885b17330f096934f175d35912c3c95825039 Raghu Kallala committed 8aa885b on branch LDT-3749-ability-to-set-operation-sub-mode-latest, LDT-3904-opmode-the-operation-mode-broad and 3 more in dd-firmware LDT-3749 addressed review comments

· /firmware/App/Modes/ModeFault.c	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModePostGenDialysate.c	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-0, +1)	| History	| Source	| Diff

]]> Fri, 10 Apr 2026 08:21:51 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28276 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28276 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3749-2

You are right, modified in all places

FALSE?

FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

Add comment that these modes not (yet?) supported.

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

· /firmware/App/Modes/ModeFault.c	(-0, +62)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.h	(-0, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-0, +67)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePostGenDialysate.c	(-0, +56)	| History	| Source	| Diff
· /firmware/App/Modes/ModePostGenDialysate.h	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-0, +61)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.h	(-0, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-0, +54)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-0, +3)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-0, +160)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.h	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +1)	| History	| Source	| Diff

]]> Mon, 06 Apr 2026 12:45:29 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3749-1 ]]> Mon, 06 Apr 2026 11:36:05 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28242 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2/#c28242 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-1195-2

Balancing chamber switching control

remove the space before false.

Remove blank line

Remove blank line.

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.