Remove this flag.

Remove this code.

Remove this condition to apply the speed for BC switch only as well.

Check the else portion and do the required changes.

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

I guess, all these checks should be moved to FillEndState.

after one state of BC switching completed. update the next comment as well.

Should we add a TODO to remove this one as well?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

Please update the function name : testDDFloaterLevelStateOverride

Why are we removing this TODO comment? It looks like we should keep it.

Do we need TODO comments to restore these alarms later?

What is the point of this message?

Looks like we need a TODO comment to restore these checks later.

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

· /firmware/App/Modes/ModeFault.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePostGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePostGenDialysate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff

]]> Wed, 22 Apr 2026 10:42:17 -0700 Raghu Kallala https://devapps.diality.us/changelog/dd-firmware?cs=21d8cec02d7e0f8ad98b54ca310243f690948ddc https://devapps.diality.us/changelog/dd-firmware?cs=21d8cec02d7e0f8ad98b54ca310243f690948ddc Raghu Kallala committed 21d8cec on branch LDT-3272-software-update---dd-firmware, LDT-3749-ability-to-set-operation-sub-mode-latest and 16 more in dd-firmware LDT-3749 resolved merge conflict with staging

· /firmware/App/Modes/ModeFault.c	(-2, +5)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-57, +58)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModePostGenDialysate.c	(-2, +5)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-2, +5)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-14, +14)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-20, +22)	| History	| Source	| Diff

]]> Wed, 22 Apr 2026 10:41:20 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-3749-2 ]]> Wed, 22 Apr 2026 09:55:43 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> Tue, 21 Apr 2026 14:17:37 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3749-2 LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem ]]> Tue, 21 Apr 2026 09:17:58 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3963-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-3963-1 ]]> Tue, 21 Apr 2026 08:34:00 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28558 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3749-2/#c28558 Raghu Kallala replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3749-2

Updated

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeFault.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeInitPOST.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePostGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeService.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-2, +2)	| History	| Source	| Diff

]]> Fri, 10 Apr 2026 11:38:33 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1195-2 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-1195-2 LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F) ]]> Fri, 10 Apr 2026 08:33:45 -0700 Raghu Kallala https://devapps.diality.us/changelog/dd-firmware?cs=8aa885b17330f096934f175d35912c3c95825039 https://devapps.diality.us/changelog/dd-firmware?cs=8aa885b17330f096934f175d35912c3c95825039 Raghu Kallala committed 8aa885b on branch LDT-3272-software-update---dd-firmware, LDT-3749-ability-to-set-operation-sub-mode-latest and 16 more in dd-firmware LDT-3749 addressed review comments

· /firmware/App/Modes/ModeFault.c	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModePostGenDialysate.c	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModePreGenDialysate.c	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-1, +3)	| History	| Source	| Diff
· /firmware/App/Modes/OperationModes.c	(-0, +1)	| History	| Source	| Diff

]]>