Fisheye on dd-firmware/firmware/App/Controllers/Heaters.c https://devapps.diality.us/changelog/~br%3DLDT-4049-standby---fw-implementation---2/dd-firmware/firmware/App/Controllers/Heaters.c Recent activity in "dd-firmware" under directory /firmware/App/Controllers/Heaters.c LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vendor - TEL - Arpita Srivastava "Add previousHeaterState to input and output" Tue, 30 Jun 2026 16:15:40 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30256 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30256 Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-4539-1

Add previousHeaterState to input and output

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vendor - TEL - Arpita Srivastava "add prevDryBicartState to input and output." Tue, 30 Jun 2026 16:13:35 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30255 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30255 Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-4539-1

add prevDryBicartState to input and output.

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vendor - TEL - Arpita Srivastava "Add prevBalChamberState to input and output" Tue, 30 Jun 2026 16:11:35 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30254 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30254 Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-4539-1

Add prevBalChamberState to input and output

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vendor - TEL - Arpita Srivastava "Add isBalChamberSwitchingActive to input" Tue, 30 Jun 2026 16:09:49 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30253 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30253 Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-4539-1

Add isBalChamberSwitchingActive to input

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vinayakam Mani "Align it with declration." Tue, 30 Jun 2026 14:40:08 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30237 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30237 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4539-1

Align it with declration.

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vinayakam Mani "Add comments." Tue, 30 Jun 2026 14:39:37 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30236 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30236 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4539-1

Add comments.

]]> LEAHI-DD-FIRMWARE-LDT-4873-1: reviewers finished Tue, 30 Jun 2026 13:46:11 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-1 Vendor - TEL - Jashwant Gantyada finished reviewing LEAHI-DD-FIRMWARE-LDT-4873-1 LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault ]]> LEAHI-DD-FIRMWARE-LDT-4873-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to... Tue, 30 Jun 2026 13:17:12 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-1 Sean Nash added Vendor - TEL - Jashwant Gantyada to LEAHI-DD-FIRMWARE-LDT-4873-1 LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault ]]> LEAHI-DD-FIRMWARE-LDT-4873-1: started by Dara Navaei Tue, 30 Jun 2026 10:02:29 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4873-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4873-1 ]]> LEAHI-DD-FIRMWARE-LDT-4246-1: closed by Raghu Kallala Wed, 24 Jun 2026 06:36:55 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4246-1 Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-4246-1 ]]> LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vinayakam Mani "Looks On event handled later. One event should ..." Thu, 18 Jun 2026 13:53:24 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30011 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30011 Vinayakam Mani replied to Vendor - TEL - Arpita Srivastava in LEAHI-DD-FIRMWARE-LDT-4539-1

Looks On event handled later. One event should be fine for On condtion.

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vinayakam Mani "Space after 0" Thu, 18 Jun 2026 13:51:21 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30010 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30010 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4539-1

Space after 0

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vinayakam Mani "prevDryBicartState" Thu, 18 Jun 2026 13:48:34 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30009 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30009 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4539-1

prevDryBicartState

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vinayakam Mani "I guess, you should use OnOff status as second ..." Thu, 18 Jun 2026 13:46:14 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30008 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30008 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4539-1

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vinayakam Mani "prevBalChamberState?" Thu, 18 Jun 2026 13:31:32 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30007 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c30007 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4539-1

prevBalChamberState?

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vendor - TEL - Arpita Srivastava "Should we also send an event when we start the ..." Thu, 18 Jun 2026 10:21:35 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c29976 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c29976 Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-4539-1

Should we also send an event when we start the heater?

]]> LEAHI-DD-FIRMWARE-LDT-4539-1: comment by Vendor - TEL - Arpita Srivastava "We can combine all these condition checks in a ..." Thu, 18 Jun 2026 10:05:58 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c29975 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4539-1/#c29975 Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-4539-1

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

]]> dd-firmware (bugfix/LDT-4539-provide-event-on-service-state-): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Thu, 11 Jun 2026 14:27:08 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=9eae2f683887bededd2240f51ddfc667d8c1d566 https://devapps.diality.us/changelog/dd-firmware?cs=9eae2f683887bededd2240f51ddfc667d8c1d566 Dara Navaei committed 9eae2f6 on branch LDT-3902-BC-switch-only-min-flow-rate, LDT-3962-request-to-add-a-concentrate-pu and 16 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/Heaters.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/RinsePump.c (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/SubstitutionPump.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/SubstitutionPump.h (-4, +4) | History | Source | Diff
· /firmware/App/Monitors/Conductivity.c (-2, +2) | History | Source | Diff
· /firmware/App/Monitors/Level.c (-2, +2) | History | Source | Diff
· /firmware/App/Monitors/Temperature.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/FpgaDD.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/FpgaDD.h (-1, +1) | History | Source | Diff
· /firmware/App/Services/Messaging.c (-2, +2) | History | Source | Diff
· /firmware/App/Services/TDInterface.c (-2, +2) | History | Source | Diff
· /firmware/App/Tasks/TaskPriority.c (-2, +2) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-4001-1: closed by Michael Garthwaite Thu, 11 Jun 2026 14:24:17 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 Michael Garthwaite Closed LEAHI-DD-FIRMWARE-LDT-4001-1 ]]> LEAHI-DD-FIRMWARE-LDT-4001-1: reviewers finished Thu, 11 Jun 2026 13:27:23 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1 Vinayakam Mani and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-4001-1 LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4: ]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 10:08:28 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29802 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29802 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Sean Nash "Should we change msg ID from speed to rate?" Thu, 11 Jun 2026 10:00:00 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29801 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29801 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4001-1

Should we change msg ID from speed to rate?

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:59:46 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29800 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29800 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "its a speed in rpm. updated function to convert..." Thu, 11 Jun 2026 09:59:23 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29799 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29799 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:58:50 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29798 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29798 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "this is a set speed in rpm" Thu, 11 Jun 2026 09:57:48 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29797 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29797 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

this is a set speed in rpm

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "this is speed in rpm" Thu, 11 Jun 2026 09:57:38 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29796 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29796 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

this is speed in rpm

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:57:26 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29795 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29795 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:57:07 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29794 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29794 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]> LEAHI-DD-FIRMWARE-LDT-4001-1: comment by Michael Garthwaite "fixed thanks" Thu, 11 Jun 2026 09:57:04 -0700 Michael Garthwaite https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29793 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4001-1/#c29793 Michael Garthwaite replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4001-1

fixed thanks

]]>