Fisheye on dd-firmware/firmware/App/Controllers/MixingControl.h https://devapps.diality.us/changelog/~br%3DLDT-5157-conductivity-sensor-calibration/dd-firmware/firmware/App/Controllers/MixingControl.h Recent activity in "dd-firmware" under directory /firmware/App/Controllers/MixingControl.h dd-firmware (LDT-4733-request-add-variables): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Mon, 13 Jul 2026 14:30:07 -0700 Dara Navaei https://devapps.diality.us/changelog/dd-firmware?cs=c992ffdef2060d3d534abd2538bfb31dd25b9fbc https://devapps.diality.us/changelog/dd-firmware?cs=c992ffdef2060d3d534abd2538bfb31dd25b9fbc Dara Navaei committed c992ffd on branch LDT-3975-water-treatment-and-degassing--, LDT-4611-hdf-fw-implementation-5-4 and 6 more in dd-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/DialysatePumps.h (-2, +2) | History | Source | Diff
· /firmware/App/Controllers/MixingControl.h (-2, +2) | History | Source | Diff
· /firmware/App/Services/TDInterface.h (-2, +2) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-2, +2) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-3902-1: reviewers resumed Mon, 13 Jul 2026 14:01:16 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3902-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3902-1 Sean Nash and Vinayakam Mani resumed reviewing LEAHI-DD-FIRMWARE-LDT-3902-1 LEAHI-DD-FIRMWARE-LDT-3902_Allow DD balancing chamber switch only command to go down to 50 mL/min ]]> dd-firmware (LDT-4733-request-add-variables): LDT-3902: Fixed mixing control warnings Mon, 13 Jul 2026 11:05:38 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/changelog/dd-firmware?cs=a8fe7791e3c46d6e1f600f83e27ce12a3bdefaf7 https://devapps.diality.us/changelog/dd-firmware?cs=a8fe7791e3c46d6e1f600f83e27ce12a3bdefaf7 Vendor - TEL - Arpita Srivastava committed a8fe779 on branch LDT-3735-non-volatile-memory, LDT-3902-BC-switch-only-min-flow-rate and 8 more in dd-firmware LDT-3902: Fixed mixing control warnings

· /firmware/App/Controllers/MixingControl.h (-0, +1) | History | Source | Diff
· /firmware/App/Services/TDInterface.h (-1, +1) | History | Source | Diff
· /firmware/App/Tasks/TaskGeneral.c (-0, +1) | History | Source | Diff
· /firmware/source/sys_main.c (-0, +1) | History | Source | Diff
]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vendor - TEL - Sameer Poyil "right now pre and post are same. make a TODO to..." Sat, 11 Jul 2026 05:38:45 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30435 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30435 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4410-3

right now pre and post are same. make a TODO to update post later

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vendor - TEL - Sameer Poyil "its mixing control interval" Sat, 11 Jul 2026 05:36:31 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30434 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30434 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-4410-3

its mixing control interval

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Vendor - TEL - Sameer Poyil "could you document th math behind the calculati..." Fri, 10 Jul 2026 16:49:14 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30433 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30433 Vendor - TEL - Sameer Poyil commented on LEAHI-DD-FIRMWARE-LDT-4410-3

could you document th math behind the calculation also

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: reviewers finished Fri, 10 Jul 2026 15:28:13 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1 Sean Nash and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-4614-1 LEAHI-DD-FIRMWARE-LDT-4614_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 5/1: ]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Sean Nash "TODO?" Wed, 08 Jul 2026 14:55:55 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30389 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30389 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4614-1

TODO?

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Remove empty line" Wed, 08 Jul 2026 14:21:52 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30388 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30388 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Remove empty line

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Remove empty line." Wed, 08 Jul 2026 14:20:23 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30387 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30387 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Remove empty line.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Please add the details what is post and pre in ..." Wed, 08 Jul 2026 13:58:46 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30385 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30385 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Please add the details what is post and pre in the comments. Also update the return type with additional details, instead of just conducitivity.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Remove extra line." Wed, 08 Jul 2026 14:01:37 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30386 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30386 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Remove extra line.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Is this TODO still valid?" Wed, 08 Jul 2026 13:52:40 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30384 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30384 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Is this TODO still valid?

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Space inside parenthesis. update across the fil..." Wed, 08 Jul 2026 13:50:56 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30383 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30383 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Space inside parenthesis. update across the file.

]]> LEAHI-DD-FIRMWARE-LDT-4410-3: comment by Sean Nash "What is 4 (or 2)? Should be #define or enum or..." Mon, 06 Jul 2026 12:59:07 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30364 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4410-3/#c30364 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4410-3

What is 4 (or 2)? Should be #define or enum or const.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Add comments." Thu, 02 Jul 2026 15:26:48 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30356 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30356 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Add comments.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Update Comments." Thu, 02 Jul 2026 15:24:32 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30354 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30354 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Update Comments.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: comment by Vinayakam Mani "Siemens. Space after and before paranthesis." Thu, 02 Jul 2026 15:22:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30353 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1/#c30353 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4614-1

Siemens. Space after and before paranthesis.

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Sean Nash "Can we be a little more specific about what con..." Wed, 01 Jul 2026 18:34:15 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30331 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30331 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Can we be a little more specific about what conductivity we are returning in these functions?
And I think we should include constants in the Inputs section of function headers.

]]> LEAHI-DD-FIRMWARE-LDT-4614-1: started by Dara Navaei Wed, 01 Jul 2026 14:32:33 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4614-1 Dara Navaei started review LEAHI-DD-FIRMWARE-LDT-4614-1 ]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vendor - TEL - Jashwant Gantyada "updated" Wed, 01 Jul 2026 10:32:39 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30294 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30294 Vendor - TEL - Jashwant Gantyada replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4719-1

updated

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vendor - TEL - Jashwant Gantyada "updated" Wed, 01 Jul 2026 10:32:23 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30293 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30293 Vendor - TEL - Jashwant Gantyada replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4719-1

updated

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vendor - TEL - Jashwant Gantyada "updated" Wed, 01 Jul 2026 10:32:17 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30292 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30292 Vendor - TEL - Jashwant Gantyada replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4719-1

updated

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vendor - TEL - Jashwant Gantyada "moved." Wed, 01 Jul 2026 10:32:10 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30291 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30291 Vendor - TEL - Jashwant Gantyada replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-4719-1

moved.

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vendor - TEL - Jashwant Gantyada "updated" Wed, 01 Jul 2026 10:32:03 -0700 Vendor - TEL - Jashwant Gantyada https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30290 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30290 Vendor - TEL - Jashwant Gantyada replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-4719-1

updated

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Sean Nash "Move below Messaging.h to keep list in alphabet..." Wed, 01 Jul 2026 09:36:18 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30268 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30268 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Move below Messaging.h to keep list in alphabetical order.

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vinayakam Mani "Same here. Let's use only D29." Tue, 30 Jun 2026 17:09:26 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30262 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30262 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Same here. Let's use only D29.

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vinayakam Mani "Suppose to use D74, Instead of D17 (for Control..." Tue, 30 Jun 2026 17:02:45 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30261 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30261 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Suppose to use D74, Instead of D17 (for Control only).

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vinayakam Mani "Move these functions to top area where all publ..." Tue, 30 Jun 2026 16:47:43 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30258 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30258 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

]]> LEAHI-DD-FIRMWARE-LDT-4719-1: comment by Vinayakam Mani "Missing Comment." Tue, 30 Jun 2026 16:44:09 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30257 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4719-1/#c30257 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-4719-1

Missing Comment.

]]>