So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

I think this enum should be in a different header file. I don't think this unit uses this enum.

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

Do these need to be public?
I think only the driver should have to know sector addresses and sizes.
If other units want to know these things, they should call a function in this driver to get them.

I think isSectorStartAddress is a better function name.

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thought this was bytes.

don't forget to add function headers.

// **************** private functions **************

I think this driver should be moved to FWCommon folder as it should work the same for both DD and TD firmware.

Add a blank line before group end marker.

No load cells in Leahi.

I think this enum belongs to NVRecords (these are records, not jobs).

I think this enum belongs to the Q (these are Q jobs), not in driver.

What about TD record CRC errors?

Are we only doing DD messages?
And since these could be coming from UI now, these shouldn't be considered "Dialin" messages anymore and should be moved up to section before 0x8000 IDs where normal system messages are defined.

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/ConcentratePumps.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Level.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff

]]> Thu, 16 Apr 2026 16:13:36 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/changelog/dd-firmware?cs=3d0c86bab8540914d9f3cfdbdd321f35db623999 https://devapps.diality.us/changelog/dd-firmware?cs=3d0c86bab8540914d9f3cfdbdd321f35db623999 Vendor - TEL - Sameer Poyil committed 3d0c86b on branch LDT-2004-dialysate-composition-dosing-control--dd, LDT-3749-ability-to-set-operation-sub-mode-latest and 11 more in dd-firmware LDT-2004 merging staging branch to LDT-2004-dialysate-composition-dosing-control--dd

· /firmware/App/Controllers/BalancingChamber.c	(-6, +6)	| History	| Source	| Diff
· /firmware/App/Controllers/DryBiCart.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Monitors/Conductivity.c	(-54, +148)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-5, +7)	| History	| Source	| Diff
· /firmware/App/Services/FpgaDD.c	(-1180, +390)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-19, +14)	| History	| Source	| Diff

]]> Thu, 16 Apr 2026 14:28:01 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28452 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28452 Vendor - TEL - Sameer Poyil replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-2004-9

Its static function and not used by external API to pass the wrong id.

0.0F is made by Sean.

· /firmware/App/Controllers/BalancingChamber.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Heaters.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Controllers/RinsePump.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Controllers/Ultrafiltration.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/DDCommon.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/TemperatureSensors.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Temperature.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff

]]> Tue, 14 Apr 2026 19:47:34 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3352-1 LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic ]]> Tue, 14 Apr 2026 19:28:15 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28365 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2004-9/#c28365 Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-2004-9

Same comment applies here (removing resetPIController).

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

Maintain space after and before parenthesis across the file.