dd-firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Is this normal UF volume or normal UF volume + Iso UF Volume?

Is this normal UF volume or normal UF volume + Iso UF Volume?

Consider moving this validity check into the setTDRequestedGenDState function. And what should we do if it's not valid?

Consider moving this validity check into the setTDRequestedGenDState function.
And what should we do if it's not valid?

Why only these states are valid?

Why only these states are valid?

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again. we need to maintain the pressure balance in chamber F

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again.
we need to maintain the pressure balance in chamber F

will address it in new file created for mixing

will address it in new file created for mixing

fixed thanks

fixed thanks

Should we change msg ID from speed to rate?

Should we change msg ID from speed to rate?

fixed thanks

fixed thanks

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

fixed thanks

fixed thanks

this is a set speed in rpm

this is a set speed in rpm

this is speed in rpm

this is speed in rpm

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

Change speed to rate.

Change speed to rate.

pumpTargetRate

pumpTargetRate

Change function name to say rate instead of speed

Change function name to say rate instead of speed

Is this a rate too?

Is this a rate too?

Is this a rate too?

Is this a rate too?

Change speed to rate.

Change speed to rate.

Is currentPumpSpeed actually a rate?

Is currentPumpSpeed actually a rate?

Is this comment correct? Seems like we're stopping pump if requested to turn off.

Is this comment correct? Seems like we're stopping pump if requested to turn off.

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

Align comment.

Align comment.