dd-firmware / firmware / App / Drivers

BloodLeakDriver.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 19 Feb
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Feb
5:14 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -3
    • +3
    ./BloodLeakDriver.c
  2. … 3 more files in changeset.
4:56 pm

Vendor - TEL - Jashwant Gantyada

4:55 pm

Sean Nash and Vendor - TEL - Sameer Poyil

2:54 pm

Vendor - TEL - Jashwant Gantyada

LDT-2030 addressed code review comments

Options
    • -15
    • +2
    ./BloodLeakDriver.c
  2. … 1 more file in changeset.
2:02 pm

Sean Nash

Can these be done without loop (just fix the size to cover both columns of the array)?

Can these be done without loop (just fix the size to cover both columns of the array)?

2:01 pm

Sean Nash

This memset should be deleted since handled above in loop now.

This memset should be deleted since handled above in loop now.

2:00 pm

Sean Nash

Add a blank line after declaration.

Add a blank line after declaration.

1:54 pm

Vendor - TEL - Sameer Poyil

implement it in a single structure packing by moving all other pragma pack

implement it in a single structure packing by moving all other pragma pack

1:50 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

changed

changed

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:45 pm

Vendor - TEL - Jashwant Gantyada

done

done

1:44 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:44 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:44 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:44 pm

Vendor - TEL - Jashwant Gantyada

declared in the header and updated them.

declared in the header and updated them.

1:43 pm

Vendor - TEL - Jashwant Gantyada

Resolved. Thanks

Resolved. Thanks

1:43 pm

Vendor - TEL - Jashwant Gantyada

Resolved. Thanks

Resolved. Thanks

1:43 pm

Vendor - TEL - Jashwant Gantyada

LDT-2030 addressed code review comments

Options
    • -76
    • +86
    ./BloodLeakDriver.c
  2. … 2 more files in changeset.
Wednesday 11 Feb
2:30 pm

Sean Nash

We can but not necessary - only necessary when using == operator.

We can but not necessary - only necessary when using == operator.

2:29 pm

Vendor - TEL - Arpita Srivastava

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

Can we write it as ( NU_EMB_MODE_CMD != expChar1 ) ?

2:23 pm

Vendor - TEL - Arpita Srivastava

Minor: There is a typo with Inputs

Minor: There is a typo with Inputs

1:34 pm

Sean Nash

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".

1:33 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:33 pm

Sean Nash

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

1:31 pm

Sean Nash

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

Some of these memset calls are zeroing a 2-dimensional array, so the size param is too short (only sizing 1st dimension).

1:28 pm

Sean Nash

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

Ok as is. We only need to have constant/literal first when using == operator to prevent confusion with = operator.

1:26 pm

Sean Nash

Actually, for casting, I prefer no spaces around ().

Actually, for casting, I prefer no spaces around ().