dd-firmware / firmware / App / Drivers

ConductivityTeensy.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 3
Last Commit: 19 Feb
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 13 Feb
3:34 pm

Sean Nash

3:34 pm

Sean Nash

1:18 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3372_Add ability to override the Teensie conductivity and temperature values directly
LEAHI-DD-FIRMWARE-LDT-3372_Add ability to override the Teensie conductivity and temperature values directly
Wednesday 11 Feb
11:18 am

Michael Garthwaite

11:01 am

Sean Nash and Vendor - TEL - Sameer Poyil

Tuesday 10 Feb
3:33 pm

Vendor - TEL - Sameer Poyil

It is there in line 131 It would be nice to have it clubbed it together like #ifdef _TEENSY_CONDUCTIVITY_DRIVER_ place all code for teensy here { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSe...

It is there in line 131

It would be nice to have it clubbed it together like

#ifdef _TEENSY_CONDUCTIVITY_DRIVER_
place all code for teensy here

Unknown macro: { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSetTeenyConductivityModel }

,
#else
// move the all code under #ifndef _TEENSY_CONDUCTIVITY_DRIVER_ here

#endif

3:13 pm

Michael Garthwaite

fixed.

fixed.

3:12 pm

Michael Garthwaite

reordered and wrapped in a macro

reordered and wrapped in a macro

3:12 pm

Michael Garthwaite

see other comment.

see other comment.

3:12 pm

Michael Garthwaite

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

3:11 pm

Michael Garthwaite

fixed.

fixed.

3:11 pm

Michael Garthwaite

removed

removed

3:10 pm

Michael Garthwaite

fixed.

fixed.

3:10 pm

Michael Garthwaite

it stop gap to see if it was valve specific. Its been reverted.

it stop gap to see if it was valve specific. Its been reverted.

10:03 am

Sean Nash

Does it make more sense to have them together?

Does it make more sense to have them together?

10:01 am

Sean Nash

Is there no "first" enum for this group?

Is there no "first" enum for this group?

10:00 am

Sean Nash

Align comment.

Align comment.

Monday 09 Feb
7:22 pm

Vendor - TEL - Sameer Poyil

arrange this code and new sensor code in a group- line 131 - 142

arrange this code and new sensor code in a group- line 131 - 142

7:19 pm

Vendor - TEL - Sameer Poyil

I think we need a #ifdef TEENSY macro ?

I think we need a #ifdef TEENSY macro ?

7:16 pm

Vendor - TEL - Sameer Poyil

Need two spaces before the test function

Need two spaces before the test function

2:03 pm

Sean Nash

This is already initialized (properly) near top of function. It is not proper (zero) here.

This is already initialized (properly) near top of function. It is not proper (zero) here.

2:01 pm

Sean Nash

Is there going to be an #else for new sensor?

Is there going to be an #else for new sensor?

1:59 pm

Sean Nash

Are we supporting multiple models? Is this for Teensy or new sensor or both?

Are we supporting multiple models? Is this for Teensy or new sensor or both?

1:58 pm

Sean Nash

Will new conductivity sensor driver have this override too? It looks Teensy specific.

Will new conductivity sensor driver have this override too? It looks Teensy specific.

Monday 02 Feb
11:37 am

Michael Garthwaite

11:01 am

Sean Nash

10:37 am

Michael Garthwaite

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Tuesday 27 Jan
1:03 pm

Michael Garthwaite

fixed. Removed ifdef as well as it is no longer applies here since we are retrieving the data from the monitor which has the #ifdefs for teensy.

fixed. Removed ifdef as well as it is no longer applies here since we are retrieving the data from the monitor which has the #ifdefs for teensy.

12:34 pm

Sean Nash

I think using filtered values for alarms makes sense.

I think using filtered values for alarms makes sense.

10:25 am

Michael Garthwaite

we need filtered values for various applications in the system. My question is should we be checking dialysate temperature using a filtered value or a sample point? This version showed that we want...

we need filtered values for various applications in the system. My question is should we be checking dialysate temperature using a filtered value or a sample point? This version showed that we want a sample point.

in Denali, looks like the HD got the filtered temperature value from the DG for checking dialysate temp alarms. Are we upholding that same design of using a filtered value for leahi dialysate temp?