leahi-dialin

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fix typo

fix typo

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:
LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:
change to td_powerOff_wARNING

change to td_powerOff_wARNING

Could you just leave it as or TBD_B7 = 0xB7 ? So it will be easy to see that the msg id location is free to use

Could you just leave it as or TBD_B7 = 0xB7 ?
So it will be easy to see that the msg id location is free to use

LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data
LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data
Update the name.

Update the name.

updated

updated

Remove extra spaces before comment

Remove extra spaces before comment

LEAHI-DIALIN-LDT-4787_NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I
LEAHI-DIALIN-LDT-4787_NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I
LDT-4747: SW Integration - FP Diagnostics - DialIn
LDT-4747: SW Integration - FP Diagnostics - DialIn
Increment the event numbers.

Increment the event numbers.