dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 21
Total Committers: 13
Last Commit: 09 Feb
Commits this week: 21

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 08 Apr
1:33 pm

Sean Nash

12:25 pm

Sean Nash

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:24 pm

Sean Nash

Remove blank line.

Remove blank line.

12:23 pm

Sean Nash

Add blank line before return.

Add blank line before return.

12:22 pm

Sean Nash

Add blank line before return.

Add blank line before return.

12:19 pm

Sean Nash

Remove blank line.

Remove blank line.

11:14 am

Vinayakam Mani

Delete the macro if not being used.

Delete the macro if not being used.

10:04 am

Sean Nash

Monday 06 Apr
2:13 pm

Vendor - TEL - Jashwant Gantyada

removed

removed

2:13 pm

Vendor - TEL - Jashwant Gantyada

updated comment.

updated comment.

2:12 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

2:12 pm

Vendor - TEL - Jashwant Gantyada

removed and added comments.

removed and added comments.

2:12 pm

Vinayakam Mani

2:12 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

2:12 pm

Vendor - TEL - Jashwant Gantyada

done. moved them to dosing concentrates state.

done. moved them to dosing concentrates state.

11:52 am

Vendor - TEL - Jashwant Gantyada and Sean Nash

11:36 am

Vinayakam Mani

Balancing chamber switching control

Balancing chamber switching control

11:32 am

Vinayakam Mani

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled f...

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled first.

11:29 am

Vinayakam Mani

remove the space before false.

remove the space before false.

11:23 am

Vinayakam Mani

Remove blank line

Remove blank line

11:23 am

Vinayakam Mani

Remove blank line.

Remove blank line.

11:00 am

Sean Nash

10:46 am

Vendor - TEL - Arpita Srivastava

I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

10:30 am

Sean Nash

Not sure these min/max are right here either.

Not sure these min/max are right here either.

10:27 am

Sean Nash

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

10:24 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

10:22 am

Vinayakam Mani

Remove this reference (across the file) if the implementation is updated.

Remove this reference (across the file) if the implementation is updated.

10:17 am

Vinayakam Mani

Update the deadband timing in the comments.

Update the deadband timing in the comments.

10:15 am

Vinayakam Mani

Remove blank line. Also, add comments on the key logics for reference.

Remove blank line. Also, add comments on the key logics for reference.