Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Add blank line before return.

Add blank line before return.

Add blank line before return.

Add blank line before return.

Remove blank line.

Remove blank line.

Delete the macro if not being used.

Delete the macro if not being used.

removed

removed

updated comment.

updated comment.

removed.

removed.

removed and added comments.

removed and added comments.

changed.

changed.

done. moved them to dosing concentrates state.

done. moved them to dosing concentrates state.

Balancing chamber switching control

Balancing chamber switching control

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled f...

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled first.

remove the space before false.

remove the space before false.

Remove blank line

Remove blank line

Remove blank line.

Remove blank line.

I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

Not sure these min/max are right here either.

Not sure these min/max are right here either.

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

Remove extra blank lines.

Remove extra blank lines.

Remove this reference (across the file) if the implementation is updated.

Remove this reference (across the file) if the implementation is updated.

Update the deadband timing in the comments.

Update the deadband timing in the comments.

Remove blank line. Also, add comments on the key logics for reference.

Remove blank line. Also, add comments on the key logics for reference.