StateFlushConcentrate.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Declare local variables at top of scope.

Declare local variables at top of scope.

Add space between ( and ?

Add space between ( and ?

Remove blank line.

Remove blank line.

Why redeclare result?

Why redeclare result?

Remove blank line.

Remove blank line.

Why are you redeclaring result? This assignment will not survive outside of the if statement.

Why are you redeclaring result? This assignment will not survive outside of the if statement.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

lower? and change the D98 level sensor comment as well.

lower? and change the D98 level sensor comment as well.

Remove empty line

Remove empty line

Space before LVL_STATE_LOW

Space before LVL_STATE_LOW

space inside array index.

space inside array index.

Space inside parenthesis.

Space inside parenthesis.

Change this to LEVEL_T enum.

Change this to LEVEL_T enum.

Is this macro still being used? if not, delete it.

Is this macro still being used? if not, delete it.

LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

removed.

removed.

changed.

changed.

removed.

removed.

the 2nd if statement for beta 1.0 is an ask from systems team to raise fault alarm if user by mistake enable Beta 2.0 config when Beta1.0 is active

the 2nd if statement for beta 1.0 is an ask from systems team to raise fault alarm if user by mistake enable Beta 2.0 config when Beta1.0 is active