leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LEAHI-DD-FIRMWARE-LDT-2008_Dialysate Composition - DD - 04: DEV - Feature Implementation
LEAHI-DD-FIRMWARE-LDT-2008_Dialysate Composition - DD - 04: DEV - Feature Implementation
LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP subsystem
LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP subsystem
Remove extra blank lines.

Remove extra blank lines.

This "s" looks out of place.

This "s" looks out of place.

But this is a f/w shared unit (so both TD and DD f/w include this unit in their build) and we may add a case later. Because it's a common unit, we should design it to work for both f/w builds.

But this is a f/w shared unit (so both TD and DD f/w include this unit in their build) and we may add a case later. Because it's a common unit, we should design it to work for both f/w builds.

No, its deleted

No, its deleted

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-TD-FIRMWARE-LDT-2240_Disposable Tube Set Self-Test - TD
LEAHI-TD-FIRMWARE-LDT-2240_Disposable Tube Set Self-Test - TD
Merge branch staging into LDT-1903-air-trap-level-control---td---0

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Updated

Updated

Added

Added

Why do we have a local sub state variable that we don't do anything with?

Why do we have a local sub state variable that we don't do anything with?

This is to avoid compilation warning

This is to avoid compilation warning

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

What is this?

What is this?

Add blank line after declarations.

Add blank line after declarations.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

else TD ?

else TD ?