td-firmware / firmware / App / Modes

ModeTreatment.c

Clone Tools

Stats

Commits this week: 8
Total Committers: 7
Last Commit: 23 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 05 May
6:54 pm

Sean Nash

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

6:52 pm

Sean Nash

2 lines above/below banner

2 lines above/below banner

6:48 pm

Sean Nash

remove blank line.

remove blank line.

6:25 pm

Sean Nash

use response.x for these.

use response.x for these.

6:25 pm

Sean Nash

use response.duration.

use response.duration.

6:24 pm

Sean Nash

Already set this above.

Already set this above.

10:55 am

Michael Garthwaite

Monday 04 May
7:14 am

Vinayakam Mani

Sunday 03 May
11:17 pm

Sean Nash

I don't think we should change this.

I don't think we should change this.

11:15 pm

Sean Nash

Not sure this makes sense. Time is in minutes. min * mL/min = mL (makes sense). min * L/hr = minL/hr (does not make sense). Talk to Raghu about UF rate units and when we should use mL/min vs. L/hr.

Not sure this makes sense. Time is in minutes. min * mL/min = mL (makes sense). min * L/hr = minL/hr (does not make sense).
Talk to Raghu about UF rate units and when we should use mL/min vs. L/hr.

11:59 am

Sean Nash

We should just have 1 of these. Let's have TD always working in mL and mL/min, and we'll just convert before sending to UI or after receiving from UI.

We should just have 1 of these. Let's have TD always working in mL and mL/min, and we'll just convert before sending to UI or after receiving from UI.

Saturday 02 May
4:33 pm

Vendor - TEL - Sameer Poyil

we don't need pragma alignment on enums, could you exclude it ?

we don't need pragma alignment on enums, could you exclude it ?

4:32 pm

Vendor - TEL - Sameer Poyil

Friday 01 May
8:07 am

Raghu Kallala

Updated to ml/min, except for broadcast in treatment mode

Updated to ml/min, except for broadcast in treatment mode

Thursday 30 Apr
3:57 pm

Sean Nash

I don't think you want stored (old) value here. You want value from first message before confirmation.

I don't think you want stored (old) value here. You want value from first message before confirmation.

1:47 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-TD-FIRMWARE-LDT-4246_FW Support for UI Demo
1:41 pm

Sean Nash

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert ...

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert to L/hr every time it needs to send UI a message. Either way works for me.

12:21 pm

Raghu Kallala

Changed to U32

Changed to U32

12:21 pm

Raghu Kallala

we are sending a message ack as response in the handler of this message request

we are sending a message ack as response in the handler of this message request

11:53 am

Raghu Kallala

Other existing set functions in TD is using UF in liter and rate in L/hr Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

Other existing set functions in TD is using UF in liter and rate in L/hr

Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

11:21 am

Michael Garthwaite and Vinayakam Mani

11:10 am

Sean Nash

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When se...

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When sending UF rate to UI, we would convert back to L/hr first, but everywhere else we would work with mL/min.

11:01 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:00 am

Sean Nash

Remove extra space before function name.

Remove extra space before function name.

11:00 am

Sean Nash

This is not a Dialin message, so move up above all of these "test" functions.

This is not a Dialin message, so move up above all of these "test" functions.

10:59 am

Sean Nash

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate dox...

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate doxygen group.

9:55 am

Vinayakam Mani

Do we have a return confirmation that the command is accepted by DD?

Do we have a return confirmation that the command is accepted by DD?

9:45 am

Vinayakam Mani

Is the UF rate unit in ml/min (instead of hr.)?

Is the UF rate unit in ml/min (instead of hr.)?

9:36 am

Vinayakam Mani

Are we assuming the sub mode return is pre-gen sub mode always?

Are we assuming the sub mode return is pre-gen sub mode always?

8:41 am

Michael Garthwaite

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here