td-firmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 14
Total Committers: 15
Last Commit: 03 Jun
Commits this week: 14

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Sean Nash

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Friday 26 Jun
3:16 pm

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

1:42 pm

Vendor - TEL - Jashwant Gantyada and Vendor - TEL - Arpita Srivastava

Wednesday 24 Jun
4:14 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:13 pm

Vendor - TEL - Varshini Nagabooshanam

Not required here since we are initializing in the main

Not required here since we are initializing in the main

4:12 pm

Vendor - TEL - Varshini Nagabooshanam

Yes removed

Yes removed

4:12 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

4:11 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

2:42 pm

Vendor - TEL - Arpita Srivastava

please add message id.

please add message id.

2:34 pm

Sean Nash

We should set all TD actuators here, not just blood pump.

We should set all TD actuators here, not just blood pump.

2:34 pm

Vendor - TEL - Arpita Srivastava

fpgaActuatorSetPoints is an output. Input is none.

fpgaActuatorSetPoints is an output.
Input is none.

2:28 pm

Vendor - TEL - Arpita Srivastava

please remove extra line

please remove extra line

2:26 pm

Vendor - TEL - Arpita Srivastava

Output is none

Output is none

2:23 pm

Vendor - TEL - Arpita Srivastava

Please add message id.

Please add message id.

2:22 pm

Vendor - TEL - Arpita Srivastava

Output is none

Output is none

2:21 pm

Vendor - TEL - Arpita Srivastava

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

1:14 pm

Sean Nash

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

1:00 pm

Sean Nash

Change "SetupConnection" to "SetupTubingSetConnection"

Change "SetupConnection" to "SetupTubingSetConnection"

12:59 pm

Sean Nash

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

12:50 pm

Sean Nash

Include "BPModule.h".

Include "BPModule.h".

12:49 pm

Sean Nash

BPModule is just one of the controllers - move this up into the controllers section.

BPModule is just one of the controllers - move this up into the controllers section.

12:48 pm

Sean Nash

We should not comment this out.

We should not comment this out.

12:47 pm

Sean Nash

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

12:46 pm

Sean Nash

We are already executing this from TaskGeneral.c. Remove from here.

We are already executing this from TaskGeneral.c. Remove from here.

12:45 pm

Sean Nash

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

12:43 pm

Sean Nash

I think all flags are outputs (not just adult).

I think all flags are outputs (not just adult).