td-firmware / firmware / App / Services

AlarmMgmtSWFaults.h

Clone Tools

Stats

Commits this week: 3
Total Committers: 7
Last Commit: 25 Mar
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
8 mins ago

Zoltan Miskolci

53 mins ago

Sean Nash

Align comments.

Align comments.

57 mins ago

Sean Nash

Can we just remove this?

Can we just remove this?

58 mins ago

Sean Nash

Can we just remove this?

Can we just remove this?

59 mins ago

Sean Nash

F suffix.

F suffix.

1 hr ago

Sean Nash

Is bicarbonate also a conversion factor?

Is bicarbonate also a conversion factor?

1 hr ago

Sean Nash

Can we just remove the old enum now?

Can we just remove the old enum now?

1 hr ago

Sean Nash

Why are we doing this?

Why are we doing this?

1 hr ago

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
1 hr ago

Raghu Kallala

Tuesday 24 Mar
2:08 pm

Zoltan Miskolci

8:16 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3554_[TD][Pressure] Data is not loading into Dialin
LEAHI-TD-FIRMWARE-LDT-3554_[TD][Pressure] Data is not loading into Dialin
Thursday 12 Mar
4:23 pm

Vendor - TEL - Varshini Nagabooshanam

4:21 pm

Vendor - TEL - Sameer Poyil and Sean Nash

4:21 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
Thursday 05 Mar
1:49 pm

Sean Nash

blank line before return.

blank line before return.

1:49 pm

Sean Nash

Blank line after declarations.

Blank line after declarations.

Wednesday 04 Mar
8:22 pm

Vendor - TEL - Sameer Poyil

Tuesday 03 Mar
4:42 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

4:42 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

4:35 pm

Sean Nash

Add a blank line after declarations.

Add a blank line after declarations.

4:35 pm

Sean Nash

What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we shoul...

What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we should reject it because we're not in the right state.
if ( ( MODE_TREA == getCurrentOperationMode() ) && ( TREATMENT_BLOOD_PRIME_STATE == getTreatmentState() ) )

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, Updated

Yes, Updated

2:55 pm

Vendor - TEL - Varshini Nagabooshanam

Replaced

Replaced

2:11 pm

Sean Nash

This should be invalid state (or something like that).

This should be invalid state (or something like that).

2:11 pm

Sean Nash

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU...

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU32TreatmentParamUpperRangeLimit() functions from the TxParams service.

2:08 pm

Sean Nash

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.

2:07 pm

Sean Nash

I think result and accepted are essentially the same. We should just have one flag and only set to TRUE if everything is correct.

I think result and accepted are essentially the same. We should just have one flag and only set to TRUE if everything is correct.