leahi-common

Clone Tools

Stats

Commits this week: 20
Total Committers: 20
Last Commit: 12 Feb
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Sean Nash

Is rinseback completed an indication that we've done a blood prime following a temporary break? If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjus...

Is rinseback completed an indication that we've done a blood prime following a temporary break?
If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjust the UF rate so that we will reach the new (larger) UF volume when the treatment completes.
We also need to add RB volume to UF volume in pre-tx when treatment parameters are given/validated (for the final rinseback which we will always have so we should just plan for it before treatment starts).

3 hrs ago

Sean Nash

What if multiple confirmations pending? Which ID will this function return?

What if multiple confirmations pending? Which ID will this function return?

4 hrs ago

Sean Nash

Align comments. Should substitution pump data be moved down to 0xBA instead of commented out?

Align comments.
Should substitution pump data be moved down to 0xBA instead of commented out?

Thursday 09 Jul
4:22 pm

Vendor - TEL - Praneeth Bunne and Sean Nash

2:07 pm

Sean Nash

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

1:36 pm

Sean Nash

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

1:33 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4040_Rinseback - FW Implementation - 3/10:
LEAHI-TD-FIRMWARE-LDT-4040_Rinseback - FW Implementation - 3/10:
1:32 pm

Sean Nash

I believe the SyringePump controller will trigger this alarm at end of seek operation.

I believe the SyringePump controller will trigger this alarm at end of seek operation.

1:28 pm

Sean Nash

Syringe pump should already be stopped if preload is done. Do we need to call this here?

Syringe pump should already be stopped if preload is done. Do we need to call this here?

1:24 pm

Sean Nash

This is called from preload state. Not needed here I think.

This is called from preload state. Not needed here I think.

1:22 pm

Sean Nash

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

1:20 pm

Sean Nash

Why (void)?

Why (void)?

1:16 pm

Sean Nash

Where is this being called? Should be called from pre-treatment init I think.

Where is this being called? Should be called from pre-treatment init I think.

1:13 pm

Sean Nash

Confirmation signal sounds like a message handler from UI. Message handlers must accept a message as parameter and return BOOL. They must also be added to the message handler table in Messaging.c.

Confirmation signal sounds like a message handler from UI. Message handlers must accept a message as parameter and return BOOL. They must also be added to the message handler table in Messaging.c.

1:11 pm

Sean Nash

Why are we signaling syringe load confirmed here?

Why are we signaling syringe load confirmed here?

1:11 pm

Sean Nash

Do these states need to be public?

Do these states need to be public?

1:08 pm

Sean Nash

Move up one row to alphabetize.

Move up one row to alphabetize.

9:48 am

Vendor - TEL - Vijay Pamula

Tuesday 07 Jul
3:57 pm

Sean Nash , Vendor - TEL - Praneeth Bunne , Zoltan Miskolci and Raghu Kallala

3:16 pm

Sean Nash

3:16 pm

Sean Nash

3:16 pm

Vendor - TEL - Praneeth Bunne

remove spaces before =

remove spaces before =

2:37 pm

Sean Nash

11:42 am

Vendor - TEL - Praneeth Bunne

change accordingly

change accordingly

11:42 am

Vendor - TEL - Praneeth Bunne

Rename to AlarmTableResposnePayload

Rename to AlarmTableResposnePayload

9:04 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Monday 06 Jul
1:56 pm

Sean Nash

1:07 pm

Sean Nash

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

1:05 pm

Sean Nash

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

10:56 am

Vendor - TEL - Praneeth Bunne