dd-firmware / firmware / App / Controllers

DryBiCart.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 26 Mar
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 01 Apr
11:34 am

Sean Nash

Algin "=" to be consistent with those below.

Algin "=" to be consistent with those below.

11:34 am

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

11:33 am

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

11:33 am

Sean Nash

Align comment.

Align comment.

11:32 am

Sean Nash

Is it time to restore?

Is it time to restore?

11:31 am

Sean Nash

Remove extra space after "=".

Remove extra space after "=".

11:29 am

Sean Nash

Are we going to restore this or not?

Are we going to restore this or not?

11:28 am

Sean Nash

Are we going to restore this or not?

Are we going to restore this or not?

11:28 am

Sean Nash

Are we going to restore this or not?

Are we going to restore this or not?

11:27 am

Sean Nash

Remove this.

Remove this.

11:26 am

Sean Nash

Remove this.

Remove this.

11:23 am

Sean Nash

Remove spaces before "=" or align "=".

Remove spaces before "=" or align "=".

11:21 am

Sean Nash

Fix comment alignment.

Fix comment alignment.

11:19 am

Sean Nash

Why are we commenting this out?

Why are we commenting this out?

11:18 am

Sean Nash

Is it time to restore now?

Is it time to restore now?

11:18 am

Sean Nash

Can we remove these 2 lines of code?

Can we remove these 2 lines of code?

Monday 30 Mar
10:15 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

10:14 am

Sean Nash

This "s" looks out of place.

This "s" looks out of place.

10:14 am

Sean Nash

But this is a f/w shared unit (so both TD and DD f/w include this unit in their build) and we may add a case later. Because it's a common unit, we should design it to work for both f/w builds.

But this is a f/w shared unit (so both TD and DD f/w include this unit in their build) and we may add a case later. Because it's a common unit, we should design it to work for both f/w builds.

Friday 27 Mar
7:56 am

Vendor - TEL - Sameer Poyil

No, its deleted

No, its deleted

7:54 am

Vendor - TEL - Sameer Poyil

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

Thursday 26 Mar
8:49 pm

Vendor - TEL - Sameer Poyil

LDT-2004 dry bicarb closed loop tuning

Options
    • -5
    • +7
    ./DryBiCart.c
  2. … 2 more files in changeset.
7:46 am

Vendor - TEL - Sameer Poyil

LDT-2004 acid bicarb closed loop control

Options
    • -10
    • +24
    ./DryBiCart.c
  2. … 3 more files in changeset.
Wednesday 25 Mar
1:35 pm

Vendor - TEL - Sameer Poyil

LDT-2004 bicarb closed loop control

Options
    • -5
    • +5
    ./DryBiCart.c
10:43 am

Vendor - TEL - Sameer Poyil

LDT-2004 Dry bicarb closed loop control

Options
    • -54
    • +858
    ./DryBiCart.c
  2. … 7 more files in changeset.
4:01 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Thursday 19 Mar
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
9:01 am

Sean Nash

Why do we have a local sub state variable that we don't do anything with?

Why do we have a local sub state variable that we don't do anything with?

Wednesday 18 Mar
8:29 pm

Vendor - TEL - Sameer Poyil

This is to avoid compilation warning

This is to avoid compilation warning

1:05 pm

Sean Nash

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.