dd-firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

Why are we removing this TODO comment? It looks like we should keep it.

Why are we removing this TODO comment? It looks like we should keep it.

Do we need TODO comments to restore these alarms later?

Do we need TODO comments to restore these alarms later?

What is the point of this message?

What is the point of this message?

Looks like we need a TODO comment to restore these checks later.

Looks like we need a TODO comment to restore these checks later.

LEAHI-DD-FIRMWARE-LDT-4183_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 2/1:
LEAHI-DD-FIRMWARE-LDT-4183_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 2/1:
LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
To resolve the build failure with DD, haven't added all the features, instead added TODO comment

To resolve the build failure with DD, haven't added all the features, instead added TODO comment

Idea is to have this in institutional records we implement it

Idea is to have this in institutional records we implement it

a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

If this is const, how will user add conversions (after 3rd value)?

If this is const, how will user add conversions (after 3rd value)?

Remove extra blank line.

Remove extra blank line.

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change? Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let ...

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change?
Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let system team be in loop to update the required system scripts?

Initialize the 'dryBicartPersistantStartTime' back to zero after timeout done, for the next iterations.

Initialize the 'dryBicartPersistantStartTime' back to zero after timeout done, for the next iterations.