dd-firmware / firmware / App / Controllers

ConcentratePumps.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 5
Last Commit: 02 Feb
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
50 mins ago

Vinayakam Mani

Same comment applies here (removing resetPIController).

Same comment applies here (removing resetPIController).

1 hr ago

Vinayakam Mani

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

1 hr ago

Vinayakam Mani

Maintain space after and before parenthesis across the file.

Maintain space after and before parenthesis across the file.

1 hr ago

Vinayakam Mani

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across th...

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across the file.

1 hr ago

Vinayakam Mani

Remove this comment.

Remove this comment.

1 hr ago

Vinayakam Mani

You may use getF32OverrideValue for consistency (across the file).

You may use getF32OverrideValue for consistency (across the file).

1 hr ago

Vinayakam Mani

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

1 hr ago

Vinayakam Mani

This is being repeated.

This is being repeated.

1 hr ago

Vinayakam Mani

Please add comment. if it is not being used, delete it.

Please add comment. if it is not being used, delete it.

1 hr ago

Vinayakam Mani

Can this be reused from ConcentratePumps.h?

Can this be reused from ConcentratePumps.h?

2 hrs ago

Vinayakam Mani

Add a space after and before parenthesis.

Add a space after and before parenthesis.

2 hrs ago

Vinayakam Mani

This comment is same as previous lines comment, update something similar to 'Maximum pressure allowed at bicart fill during supply process/state"

This comment is same as previous lines comment, update something similar to 'Maximum pressure allowed at bicart fill during supply process/state"

2 hrs ago

Vinayakam Mani

Add comment. is this the pressure offset for 11 PSI, if so, this offset supposed to be 1?

Add comment. is this the pressure offset for 11 PSI, if so, this offset supposed to be 1?

2 hrs ago

Vinayakam Mani

Please update this value with high resolution ( for example, 0.67 to 0.666666667 and 1.15 to 1.146666667? ).

Please update this value with high resolution ( for example, 0.67 to 0.666666667 and 1.15 to 1.146666667? ).

2 hrs ago

Sean Nash

2 hrs ago

Sean Nash

So I think this compiler will give you 64 bit if you ask for long. Did you intend it to be 64 bit? If not, you can just use the BIT_BY_POS macro above.

So I think this compiler will give you 64 bit if you ask for long. Did you intend it to be 64 bit? If not, you can just use the BIT_BY_POS macro above.

4 hrs ago

Vendor - TEL - Sameer Poyil

Removing it now. will introduce it later if required

Removing it now. will introduce it later if required

4 hrs ago

Vendor - TEL - Sameer Poyil

will finalize it when ocean spray logic is tested

will finalize it when ocean spray logic is tested

4 hrs ago

Vendor - TEL - Sameer Poyil

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate

4 hrs ago

Vendor - TEL - Sameer Poyil

removed

removed

4 hrs ago

Vendor - TEL - Sameer Poyil

This is not extra blank line its a line for TASK_GENERAL_INTERVAL )

This is not extra blank line its a line for TASK_GENERAL_INTERVAL )

4 hrs ago

Vendor - TEL - Sameer Poyil

a macro used to create a contiguous bitmask starting at bit position l (low) and ending at bit position h

a macro used to create a contiguous bitmask starting at bit position l (low) and ending at bit position h

4 hrs ago

Vendor - TEL - Sameer Poyil

nr means short form of bit 'number', unsigned long is portable, 32bit for 32-bit cpu and 64 bits for 64bit cpu whereas unsigned int is always 32 bits regardless of architecture.

nr means short form of bit 'number', unsigned long is portable, 32bit for 32-bit cpu and 64 bits for 64bit cpu whereas unsigned int is always 32 bits regardless of architecture.

5 hrs ago

Sean Nash

Remove this blank line.

Remove this blank line.

5 hrs ago

Sean Nash

Put () around each of the 2 conditions being ANDed.

Put () around each of the 2 conditions being ANDed.

5 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

5 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

5 hrs ago

Sean Nash

Add a blank line after declarations.

Add a blank line after declarations.

5 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

5 hrs ago

Sean Nash

Should we remove this else if or is it going to be restored later?

Should we remove this else if or is it going to be restored later?