Activity dd-firmware/firmware/App/Modes/ModeStandby.c

1 hr ago

Vendor - TEL - Arpita Srivastava

11:52 am

Vinayakam Mani

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

11:38 am

Sean Nash and Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-1195-2
finished reviewing

8:21 am

Raghu Kallala

You are right, modified in all places

1:51 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3749-2
commented on review

FALSE?

1:50 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3749-2
commented on review

FALSE?

1:46 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3749-2
commented on review

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

1:44 pm

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always ha...

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

1:41 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3749-2
commented on review

Add comment that these modes not (yet?) supported.

8:24 am

Dara Navaei

2:54 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3749-2
commented on review

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we imple...

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

1:00 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3749-2
started review

LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem

12:45 pm

Raghu Kallala

11:36 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

Balancing chamber switching control

11:29 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

remove the space before false.

11:23 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

Remove blank line

11:23 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-1195-2
commented on review

Remove blank line.

11:00 am

Sean Nash

10:46 am

Vendor - TEL - Arpita Srivastava

I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

10:17 am