Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove Dialysate from the handler name.

Remove Dialysate from the handler name.

Add Comment. Rename macro as UF_VOL_ML_PER_TASK_INTERVAL

Add Comment. Rename macro as UF_VOL_ML_PER_TASK_INTERVAL

Can we move this exec at task level, independent of Drybicart operations?

Can we move this exec at task level, independent of Drybicart operations?

Comment missing?

Comment missing?

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5...

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5 cycles of balancing chamber switching time.

both acid and bicarb mix volume

both acid and bicarb mix volume

Add MULTIPLIER at the end.

Add MULTIPLIER at the end.

Initialize at init function.

Initialize at init function.

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

Lets remove this.

Lets remove this.

LEAHI-DD-FIRMWARE-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
LEAHI-DD-FIRMWARE-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
Looks On event handled later. One event should be fine for On condtion.

Looks On event handled later. One event should be fine for On condtion.

Space after 0

Space after 0

prevDryBicartState

prevDryBicartState

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

prevBalChamberState?

prevBalChamberState?

Should we also send an event when we start the heater?

Should we also send an event when we start the heater?

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line. The code will still work if we remove the first condition c...

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

Remove blank line.

Remove blank line.

I will mark it as TODO , so you can close it

I will mark it as TODO , so you can close it

Update name.

Update name.

Add a Todo comment to resolve the issue.

Add a Todo comment to resolve the issue.