dd-firmware / firmware / App / Controllers

RinsePump.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 3
Last Commit: 12 Feb
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Apr
12:10 pm

Vinayakam Mani

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Sunday 26 Apr
12:42 pm

Sean Nash

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Tuesday 21 Apr
9:17 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:
LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:
Friday 03 Apr
9:31 am

Vendor - TEL - Jashwant Gantyada

8:32 am

Sean Nash

Thursday 02 Apr
3:35 pm

Vinayakam Mani

Tuesday 31 Mar
9:36 am

Sean Nash

Wednesday 25 Mar
4:01 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Thursday 19 Mar
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Monday 16 Mar
1:52 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1
LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1
Tuesday 24 Feb
11:55 am

Vendor - TEL - Jashwant Gantyada

10:35 am

Raghu Kallala , Vinayakam Mani and Sean Nash

Monday 23 Feb
1:18 pm

Vendor - TEL - Jashwant Gantyada

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
Friday 20 Feb
2:19 pm

Vendor - TEL - Sameer Poyil

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

2:17 pm

Vendor - TEL - Sameer Poyil

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

1:42 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

1:42 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

1:41 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

12:50 pm

Raghu Kallala

the 2nd if statement for beta 1.0 is an ask from systems team to raise fault alarm if user by mistake enable Beta 2.0 config when Beta1.0 is active

the 2nd if statement for beta 1.0 is an ask from systems team to raise fault alarm if user by mistake enable Beta 2.0 config when Beta1.0 is active

11:03 am

Sean Nash

Noe says we can distinguish between beta 1.9 and 2.0 w/ ID (4 and 6). We still need test configs for beta 1.0 stuff and non-fpga differences. We can use DD fpga ID # here in this macro instead of t...

Noe says we can distinguish between beta 1.9 and 2.0 w/ ID (4 and 6).
We still need test configs for beta 1.0 stuff and non-fpga differences.
We can use DD fpga ID # here in this macro instead of test config.
Since this is all temporary, I'm not that concerned about how we do this so long as it works.

10:22 am

Sean Nash

I think Sameer is saying that the monitor should just call one get level function in FPGA and that one function (in FpgaDD.c) would handle all of this beta 1/1.9/2.0 stuff. I agree, but didn't comm...

I think Sameer is saying that the monitor should just call one get level function in FPGA and that one function (in FpgaDD.c) would handle all of this beta 1/1.9/2.0 stuff.
I agree, but didn't comment on it because it's all temporary anyway.

9:59 am

Sean Nash

Why do we need a get function to call another get function? The caller of this function should just call getFPGAGPIOStatus() and then we wouldn't need this.

Why do we need a get function to call another get function? The caller of this function should just call getFPGAGPIOStatus() and then we wouldn't need this.

9:46 am

Sean Nash

Move this up to public definitions section.

Move this up to public definitions section.

7:59 am

Raghu Kallala

readFloaterLevelStatus is higher level functions that give the data from the FPGA. Reason why we had these get functions here is, based on the FPGA response we translate it to the user understandab...

readFloaterLevelStatus is higher level functions that give the data from the FPGA.
Reason why we had these get functions here is, based on the FPGA response we translate it to the user understandable enum values (low, medium, high)

7:55 am

Raghu Kallala

This is a reset call, as the default requirement is to be on Beta 1.9 HW The logic is checking if the user is resetting the Beta 2.0 config, if yes, we will have to fall back to the Beta 1.9 FPGA r...

This is a reset call, as the default requirement is to be on Beta 1.9 HW
The logic is checking if the user is resetting the Beta 2.0 config, if yes, we will have to fall back to the Beta 1.9 FPGA registers

1:05 am

Vendor - TEL - Sameer Poyil

Level.c is a higher level abstracted functions and should not implement the HW dependent details in this file. this details should be pushed to FPGADD. and single function should handle all the cas...

Level.c is a higher level abstracted functions and should not implement the HW dependent details in this file. this details should be pushed to FPGADD. and single function should handle all the cases instead of multiple functions.

12:29 am

Vendor - TEL - Sameer Poyil

Its not required, HW should be auto detected and initialized without any user configuration.

Its not required, HW should be auto detected and initialized without any user configuration.

12:25 am

Vendor - TEL - Sameer Poyil

why its checking beta 2 and then setting beta 1.9 HW ?

why its checking beta 2 and then setting beta 1.9 HW ?

12:22 am

Vendor - TEL - Sameer Poyil

We don't need this complex logic . use getFPGAVersions() function

We don't need this complex logic . use getFPGAVersions() function

12:18 am

Vendor - TEL - Sameer Poyil

use getFPGAVersions() to check this . if Beta 1.9 , FPGA version id is 4 and 6 if beta 2.0

use getFPGAVersions() to check this . if Beta 1.9 , FPGA version id is 4 and 6 if beta 2.0