dd-firmware / firmware / App / Modes / FPModes

FPOperationModes.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 4
Last Commit: 06 Mar
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Mar
2:48 pm

Sean Nash

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

2:46 pm

Sean Nash

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request. We should do whatever is needed (if an...

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request.
We should do whatever is needed (if anything) to start the mode normally in an else.
And we should return TRUE/FALSE in these signal functions so that when it's called from Dialin msg handler, the msg handler can return ACK/NAK to Dialin if sub mode is invalid.

2:42 pm

Sean Nash

We shouldn't request op mode until we're sure we're happy with the whole thing. Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just re...

We shouldn't request op mode until we're sure we're happy with the whole thing.
Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just request new sub mode if not already in it. If not, the currentSubMode checked below is not relevant (applies to current mode, not the requested mode) and we need to request new op mode and signal that new op mode that we will want to start in a specific sub mode.

2:38 pm

Sean Nash

Declarations should be at top of scope (right before memcpy).

Declarations should be at top of scope (right before memcpy).

2:37 pm

Sean Nash

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

2:36 pm

Sean Nash

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

2:34 pm

Sean Nash

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

12:47 pm

Raghu Kallala

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode? Sean NashMichael Garthwaite please confirm

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean NashMichael Garthwaite please confirm

12:37 pm

Raghu Kallala

I was thinking we could return BOOL to check if the request was successful, added it. But as you clarified the dialin response will only confirm the delivery of message successfully, I can change ...

I was thinking we could return BOOL to check if the request was successful, added it.

But as you clarified the dialin response will only confirm the delivery of message successfully, I can change all these signal functions to void
Thanks!

9:58 am

Michael Garthwaite

Yes since you're not using the return value in execOpModes()

Yes since you're not using the return value in execOpModes()

Thursday 05 Mar
7:32 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP sub system
LEAHI-DD-FIRMWARE-LDT-3603_Ability to set operation sub mode on IOFP sub system
Thursday 15 Jan
4:08 pm

Raghu Kallala

2:33 pm

Michael Garthwaite and Sean Nash

1:54 pm

Raghu Kallala

1:34 pm

Raghu Kallala

Updated, Thanks

Updated, Thanks

1:24 pm

Sean Nash

Fix return description. This function is not setting anything. Should be something like TRUE if request handled successfully.

Fix return description. This function is not setting anything. Should be something like TRUE if request handled successfully.

1:22 pm

Raghu Kallala

Fixed

Fixed

1:19 pm

Sean Nash

Fix comment.

Fix comment.

1:16 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3159_[Request] A getter function to read the DD FW for the defeatureized state
LEAHI-DD-FIRMWARE-LDT-3159_[Request] A getter function to read the DD FW for the defeatureized state
Wednesday 24 Dec 2025
9:49 am

Dara Navaei

9:49 am

Dara Navaei

Friday 14 Nov 2025
5:03 pm

Sean Nash

3:19 pm

Raghu Kallala , Vinayakam Mani and Dara Navaei

11:24 am

Dara Navaei

Done

Done

11:23 am

Dara Navaei

No I removed it.

No I removed it.

10:56 am

Sean Nash

I will resolve this for now, but I don't think ACKs are necessary and I'm pretty sure TD is not looking for a response. TD may be waiting for DD to change mode by looking at DD mode broadcasts.

I will resolve this for now, but I don't think ACKs are necessary and I'm pretty sure TD is not looking for a response. TD may be waiting for DD to change mode by looking at DD mode broadcasts.

Thursday 13 Nov 2025
9:56 am

Michael Garthwaite

fixed. thanks

fixed. thanks

9:15 am

Michael Garthwaite

I think so. the TD needs to know if we are successful in stopping Gen mode for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen. whether that should be a s...

I think so. the TD needs to know if we are successful in stopping Gen mode for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

9:14 am

Michael Garthwaite

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen. whether that should ...

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

9:14 am

Michael Garthwaite

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen. whether that should ...

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.