leahi-common

Clone Tools

Stats

Commits this week: 23
Total Committers: 15
Last Commit: 13:55
Commits this week: 23

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Vendor - TEL - Sameer Poyil

It is there in line 131 It would be nice to have it clubbed it together like #ifdef _TEENSY_CONDUCTIVITY_DRIVER_ place all code for teensy here { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSe...

It is there in line 131

It would be nice to have it clubbed it together like

#ifdef _TEENSY_CONDUCTIVITY_DRIVER_
place all code for teensy here

Unknown macro: { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSetTeenyConductivityModel }

,
#else
// move the all code under #ifndef _TEENSY_CONDUCTIVITY_DRIVER_ here

#endif

4 hrs ago

Michael Garthwaite

fixed.

fixed.

4 hrs ago

Michael Garthwaite

reordered and wrapped in a macro

reordered and wrapped in a macro

4 hrs ago

Michael Garthwaite

see other comment.

see other comment.

4 hrs ago

Michael Garthwaite

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

4 hrs ago

Michael Garthwaite

fixed.

fixed.

4 hrs ago

Michael Garthwaite

removed

removed

4 hrs ago

Michael Garthwaite

fixed.

fixed.

4 hrs ago

Michael Garthwaite

it stop gap to see if it was valve specific. Its been reverted.

it stop gap to see if it was valve specific. Its been reverted.

5 hrs ago

Sean Nash and Michael Garthwaite

5 hrs ago

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /DDDefs.h
    • -2
    • +2
    /MsgDefs.h
6 hrs ago

Vendor - TEL - Sameer Poyil and Sean Nash

7 hrs ago

Vendor - TEL - Sameer Poyil

LDT-2004-3 Merging branch staging into LDT-2004-drybicarb---dd

Options
    • -2
    • +2
    /DDDefs.h
    • -2
    • +13
    /MsgDefs.h
8 hrs ago

Sean Nash

Add TODO to comment.

Add TODO to comment.

8 hrs ago

Sean Nash

Put () around the 2 conditions

Put () around the 2 conditions

9 hrs ago

Sean Nash

Does it make more sense to have them together?

Does it make more sense to have them together?

9 hrs ago

Sean Nash

Is there no "first" enum for this group?

Is there no "first" enum for this group?

9 hrs ago

Sean Nash

Align comment.

Align comment.

12 hrs ago

Raghu Kallala

Resolved

Resolved

12 hrs ago

Raghu Kallala

Updated

Updated

12 hrs ago

Raghu Kallala

Updated

Updated

Monday 09 Feb
7:22 pm

Vendor - TEL - Sameer Poyil

arrange this code and new sensor code in a group- line 131 - 142

arrange this code and new sensor code in a group- line 131 - 142

7:19 pm

Vendor - TEL - Sameer Poyil

I think we need a #ifdef TEENSY macro ?

I think we need a #ifdef TEENSY macro ?

7:16 pm

Vendor - TEL - Sameer Poyil

Need two spaces before the test function

Need two spaces before the test function

2:03 pm

Sean Nash

This is already initialized (properly) near top of function. It is not proper (zero) here.

This is already initialized (properly) near top of function. It is not proper (zero) here.

2:01 pm

Sean Nash

Is there going to be an #else for new sensor?

Is there going to be an #else for new sensor?

1:59 pm

Sean Nash

Are we supporting multiple models? Is this for Teensy or new sensor or both?

Are we supporting multiple models? Is this for Teensy or new sensor or both?

1:58 pm

Sean Nash

Will new conductivity sensor driver have this override too? It looks Teensy specific.

Will new conductivity sensor driver have this override too? It looks Teensy specific.

1:12 pm

Sean Nash

Align comments.

Align comments.

1:11 pm

Sean Nash

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".