leahi-common

DDDefs.h

Clone Tools

Stats

Commits this week: 9
Total Committers: 10
Last Commit: 02 Feb
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 04 Feb
4:57 pm

Vendor - TEL - Varshini Nagabooshanam

4:53 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

4:36 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
2:34 pm

Vendor - TEL - Varshini Nagabooshanam

Commented out already but I dont know why it is showing the same

Commented out already but I dont know why it is showing the same

2:10 pm

Sean Nash

It's still UI only. Shouldn't this be commented out before we merge?

It's still UI only. Shouldn't this be commented out before we merge?

12:05 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, updated

Yes, updated

12:05 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

11:45 am

Sean Nash

Remove blank line.

Remove blank line.

11:43 am

Sean Nash

Looks like this reverted back.

Looks like this reverted back.

10:24 am

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

Tuesday 03 Feb
5:23 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

5:17 pm

Sean Nash

It is your comment, so please resolve it.

It is your comment, so please resolve it.

3:12 pm

Vendor - TEL - Sameer Poyil

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

2:04 pm

Vendor - TEL - Sameer Poyil

It will be fixed in Balancing chamber re-implementation

It will be fixed in Balancing chamber re-implementation

1:45 pm

Vendor - TEL - Sameer Poyil

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

Monday 02 Feb
3:41 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

3:39 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

3:17 pm

Vendor - TEL - Sameer Poyil

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working ) //Increment counter for dry bicarb c...

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working )

//Increment counter for dry bicarb chamber fill
bicarbChamberPeriodicFillCounter += 1;
// Fill bicarb chamber once every 60secs.
if ( bicarbChamberPeriodicFillCounter >= BICARB_CHAMBER_PERIODIC_FILL_TIME )

Unknown macro: { setBicarbChamberFillRequested(); bicarbChamberPeriodicFillCounter = 0; }


The request is cleared here. for consistency I am moving to the end of the fill cycle

1:30 pm

Sean Nash

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
11:42 am

Vendor - TEL - Varshini Nagabooshanam

Yes, we do and this is not required here so, I removed

Yes, we do and this is not required here so, I removed

11:03 am

Sean Nash

Shouldn't we be getting these defaults from the TxParams unit?

Shouldn't we be getting these defaults from the TxParams unit?

9:48 am

Vendor - TEL - Varshini Nagabooshanam

Yes, Updated

Yes, Updated

9:29 am

Sean Nash

Why is this flag set to FALSE here in start state while the other request flags are set to FALSE in their completed states?

Why is this flag set to FALSE here in start state while the other request flags are set to FALSE in their completed states?

9:28 am

Sean Nash

Should there be any constraints to setting these request flags to TRUE? What if drain request is still in progress for example? Shouldn't drain finish before fill starts? This wouldn't be an issue ...

Should there be any constraints to setting these request flags to TRUE? What if drain request is still in progress for example? Shouldn't drain finish before fill starts?
This wouldn't be an issue if we combined the 3 state machines.

9:18 am

Sean Nash

I think this should be commented out before we merge to staging.

I think this should be commented out before we merge to staging.

Friday 30 Jan
10:14 pm

Vendor - TEL - Sameer Poyil

Complex conditional expressions can be avoided. Introduce temporary boolean variables instead. for example if ((elementNo < 0) || (elementNo > maxElement)|| elementNo == lastElement){ … } should b...

Complex conditional expressions can be avoided. Introduce
temporary boolean variables instead.

for example
if ((elementNo < 0) || (elementNo > maxElement)||
elementNo == lastElement)

Unknown macro: { … }


should be replaced by:
isFinished = (elementNo < 0) || (elementNo > maxElement);
isRepeatedEntry = elementNo == lastElement;
if ((isFinished == TRUE) || (isRepeatedEntry == TRUE))

4:32 pm

Vendor - TEL - Sameer Poyil

its rate , pump speed in ml/min

its rate , pump speed in ml/min

3:04 pm

Vendor - TEL - Sameer Poyil

Fixed.

Fixed.

3:02 pm

Vendor - TEL - Sameer Poyil

When flag is true and Drain complete , it remains in the DRY_BICART_FLUID_DRAIN_END_STATE, when it is cleared, it go back to DRY_BICART_DRAIN_START_STATE Its fixed now

When flag is true and Drain complete , it remains in the DRY_BICART_FLUID_DRAIN_END_STATE, when it is cleared, it go back to DRY_BICART_DRAIN_START_STATE
Its fixed now

12:12 pm

Sean Nash

It looks to me like the state machine (drain for example) will keep running so long as the flag is true. I would think it should set the flag to false when drain is done.

It looks to me like the state machine (drain for example) will keep running so long as the flag is true. I would think it should set the flag to false when drain is done.