leahi-dialin / leahi_dialin / td / modules

air_pump.py

Clone Tools

Stats

Commits this week: 2
Total Committers: 6
Last Commit: 03 Mar
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 03 Mar
4:58 pm

Michael Garthwaite

3:28 pm

Zoltan Miskolci

removed

removed

9:13 am

Michael Garthwaite

Remove this extra line

Remove this extra line

Friday 27 Feb
1:57 am

Zoltan Miskolci and Sean Nash

Friday 20 Feb
2:16 pm

Zoltan Miskolci

1:16 pm

Raghu Kallala and Michael Garthwaite

10:46 am

Dara Navaei

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
9:31 am

Dara Navaei

LEAHI-DIALIN-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-DIALIN-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
Tuesday 17 Feb
2:49 pm

Dara Navaei

2:49 pm

Dara Navaei

2:04 pm

Dara Navaei

LEAHI-DIALIN-LDT-3554_[TD][Pressure] Data is not loading into Dialin
LEAHI-DIALIN-LDT-3554_[TD][Pressure] Data is not loading into Dialin
Wednesday 11 Feb
12:00 pm

Zoltan Miskolci

9:54 am

Raghu Kallala and Michael Garthwaite

9:50 am

Zoltan Miskolci

Tuesday 10 Feb
2:35 pm

Dara Navaei

LEAHI-DIALIN-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
LEAHI-DIALIN-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
Friday 06 Feb
10:56 am

Vendor - TEL - Jashwant Gantyada

10:53 am

Zoltan Miskolci and Sean Nash

9:32 am

Vendor - TEL - Jashwant Gantyada

Done.

Done.

9:26 am

Sean Nash

Can we make 255 a constant with a name like MAX_AIR_PUMP_POWER_LEVEL to make it clear what we're doing here?

Can we make 255 a constant with a name like MAX_AIR_PUMP_POWER_LEVEL to make it clear what we're doing here?

9:02 am

Dara Navaei

LEAHI-DIALIN-LDT-2316_Max allowed H12 power needs to be updated
LEAHI-DIALIN-LDT-2316_Max allowed H12 power needs to be updated
Thursday 22 Jan
10:07 am

Zoltan Miskolci

Wednesday 21 Jan
12:35 pm

Sean Nash

11:08 am

Zoltan Miskolci

10:31 am

Raghu Kallala and Michael Garthwaite

9:47 am

Zoltan Miskolci

Tuesday 20 Jan
3:33 pm

Tiffany Mejia

10:14 am

Zoltan Miskolci

I added the unique decorator back, except for the few that have aliases

I added the unique decorator back, except for the few that have aliases

9:32 am

Zoltan Miskolci

Renamed, also flagged for future type change.

Renamed, also flagged for future type change.

Monday 19 Jan
11:52 am

Michael Garthwaite

"No one should interact with it or be aware of it's existence, so the name shouldn't matter." *it matters to those who read the code in inconsistent intervals ( like those who participate in code...

"No one should interact with it or be aware of it's existence, so the name shouldn't matter."

  • it matters to those who read the code in inconsistent intervals ( like those who participate in code review or teaching ).


"As we only have 2 version in test at the same time."

  • Currently. By summer, i'd expect dialin to be considering 1.0's, 1.9s, and 2.0s/DVTs.


We have the choice to handle the redesign effort then or now.


Edit:
Follow up comment.

Looking at the other files. Users of dialin will not be aware of existence, but developers of dialin will as it impacts the behavior of overrides like temp & pressure.

11:48 am

Michael Garthwaite

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique ke...

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique keyword to fail. These will not trigger an exception ).