Ultrafiltration.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
seems to be old , need to merge the staging code

seems to be old , need to merge the staging code

align the comment

align the comment

complicated check should be replaced with boolean flag

complicated check should be replaced with boolean flag

Variable name is not understood -temDataCollectionTimeInterval ?

Variable name is not understood -temDataCollectionTimeInterval ?

Yes. updated.

Yes. updated.

So shouldn't we stop trimmer heater here then?

So shouldn't we stop trimmer heater here then?

Done.

Done.

Done

Done

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should...

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

Mis-spelled "Stabilized".

Mis-spelled "Stabilized".

I think you can do this in 1 line of code using the RANGE macro in Common.h.

I think you can do this in 1 line of code using the RANGE macro in Common.h.

What should trimmer heater be doing in these spent/bicarb chamber states?

What should trimmer heater be doing in these spent/bicarb chamber states?

I would think this would be enabled by default.

I would think this would be enabled by default.

LEAHI-DD-FIRMWARE-LDT-1473_Ultrafiltration - DD
LEAHI-DD-FIRMWARE-LDT-1473_Ultrafiltration - DD
DD-LDT-1473_Ultrafiltration DD
DD-LDT-1473_Ultrafiltration DD
Thanks. Resolved

Thanks. Resolved

it is moved to DDDef.h, UI team is looking for this mapping for their (diagnostics page) development.

it is moved to DDDef.h, UI team is looking for this mapping for their (diagnostics page) development.

Where did this valve enum go?

Where did this valve enum go?

Done.

Done.

I have introduced two additional build flags in 'DDCommon.h' (ENABLE_ALARM_1 and ENABLE_ALARM_2) to currently stop triggering alarms due to hardware support etc., so. it should be safe for now. if ...

I have introduced two additional build flags in 'DDCommon.h' (ENABLE_ALARM_1 and ENABLE_ALARM_2) to currently stop triggering alarms due to hardware support etc., so. it should be safe for now. if still any specific alarms triggers, will try to disable those alarms.

2 blank lines above and below test support banners.

2 blank lines above and below test support banners.

Is this safe to enable now?

Is this safe to enable now?

LDT-1473 code update

  1. … 2 more files in changeset.
LDT-1473 UF code update

  1. … 4 more files in changeset.
Consider doing this in update compensated rate function (only once every 2 minutes when rate actually changes).

Consider doing this in update compensated rate function (only once every 2 minutes when rate actually changes).

LDT-1473 UF compensation

  1. … 3 more files in changeset.