dd-firmware / firmware / App / Services

AlarmMgmtSWFaults.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 9
Last Commit: 23 Jan
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Sean Nash

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

3 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

3 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

3 hrs ago

Sean Nash

Add blank line before return.

Add blank line before return.

3 hrs ago

Sean Nash

Add blank line before return.

Add blank line before return.

3 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

Monday 06 Apr
10:30 am

Sean Nash

Not sure these min/max are right here either.

Not sure these min/max are right here either.

10:27 am

Sean Nash

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

10:24 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

Friday 03 Apr
3:35 pm

Vinayakam Mani

Done.

Done.

3:34 pm

Vinayakam Mani

Done

Done

3:34 pm

Vinayakam Mani

Done.

Done.

1:20 pm

Sean Nash

Same comment.

Same comment.

1:19 pm

Sean Nash

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

1:14 pm

Sean Nash

Input is d78TempAvgC

Input is d78TempAvgC

1:13 pm

Sean Nash

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

Thursday 02 Apr
3:43 pm

Vinayakam Mani

Done.

Done.

3:43 pm

Vinayakam Mani

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

3:40 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

9:37 am

Dara Navaei

9:37 am

Dara Navaei

Wednesday 01 Apr
11:34 am

Sean Nash

Algin "=" to be consistent with those below.

Algin "=" to be consistent with those below.

11:34 am

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

11:33 am

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

11:33 am

Sean Nash

Align comment.

Align comment.

11:32 am

Sean Nash

Is it time to restore?

Is it time to restore?

11:31 am

Sean Nash

Remove extra space after "=".

Remove extra space after "=".

11:29 am

Sean Nash

Are we going to restore this or not?

Are we going to restore this or not?