dd-firmware / firmware / App

Tasks

Clone Tools

Stats

Commits this week: 7
Total Committers: 9
Last Commit: 13 Mar
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 18 Jun
1:53 pm

Vinayakam Mani

Looks On event handled later. One event should be fine for On condtion.

Looks On event handled later. One event should be fine for On condtion.

1:51 pm

Vinayakam Mani

Space after 0

Space after 0

1:48 pm

Vinayakam Mani

prevDryBicartState

prevDryBicartState

1:46 pm

Vinayakam Mani

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

1:31 pm

Vinayakam Mani

prevBalChamberState?

prevBalChamberState?

10:21 am

Vendor - TEL - Arpita Srivastava

Should we also send an event when we start the heater?

Should we also send an event when we start the heater?

10:11 am

Vendor - TEL - Arpita Srivastava

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line. The code will still work if we remove the first condition c...

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

Tuesday 16 Jun
1:24 pm

Vendor - TEL - Jashwant Gantyada and Vinayakam Mani

1:16 pm

Vendor - TEL - Jashwant Gantyada

11:55 am

Vinayakam Mani

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

10:33 am

Vendor - TEL - Sameer Poyil

I will mark it as TODO , so you can close it

I will mark it as TODO , so you can close it

10:24 am

Vinayakam Mani

Update name.

Update name.

10:22 am

Vinayakam Mani

Add a Todo comment to resolve the issue.

Add a Todo comment to resolve the issue.

10:20 am

Vinayakam Mani

Align the indentation.

Align the indentation.

10:17 am

Vinayakam Mani

Align the indentation.

Align the indentation.

10:15 am

Vinayakam Mani

Do we need these comments? delete it if not required.

Do we need these comments? delete it if not required.

10:11 am

Vinayakam Mani

Align the indent

Align the indent

Monday 15 Jun
2:17 pm

Vinayakam Mani

Remove empty line

Remove empty line

2:16 pm

Vinayakam Mani

Remove unused header files.

Remove unused header files.

2:15 pm

Vinayakam Mani

Remove empty line.

Remove empty line.

2:14 pm

Vinayakam Mani

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

2:11 pm

Vinayakam Mani

Initialize result to open loop state and remove the open loop state assignment later.

Initialize result to open loop state and remove the open loop state assignment later.

12:29 pm

Vinayakam Mani

Remove the blank line

Remove the blank line

12:28 pm

Vinayakam Mani

Add headers for all below functions.

Add headers for all below functions.

12:27 pm

Vinayakam Mani

Rmove extra blank line

Rmove extra blank line

12:19 pm

Vinayakam Mani

Update Input section: Balancing chamber state

Update Input section: Balancing chamber state

12:18 pm

Vinayakam Mani

We can keep it as handler instead of exec since this is being invoked from execMixingControl.

We can keep it as handler instead of exec since this is being invoked from execMixingControl.

12:04 pm

Vinayakam Mani

we should use get balancing chamber fill volume if balancing chamber volume been adjusted by calibration (not an immediate need, but good to have)

we should use get balancing chamber fill volume if balancing chamber volume been adjusted by calibration (not an immediate need, but good to have)

11:58 am

Vinayakam Mani

remove min in the comment.

remove min in the comment.

11:55 am

Vinayakam Mani

Remove the unused header file.

Remove the unused header file.