leahi-fwcommon

Clone Tools

Stats

Commits this week: 11
Total Committers: 13
Last Commit: 12 Mar
Commits this week: 11

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
12 hrs ago

Vendor - TEL - Sameer Poyil

No, its deleted

No, its deleted

12 hrs ago

Vendor - TEL - Sameer Poyil

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

Wednesday 25 Mar
11:16 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
4:01 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Thursday 19 Mar
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
9:01 am

Sean Nash

Why do we have a local sub state variable that we don't do anything with?

Why do we have a local sub state variable that we don't do anything with?

Wednesday 18 Mar
8:29 pm

Vendor - TEL - Sameer Poyil

This is to avoid compilation warning

This is to avoid compilation warning

1:05 pm

Sean Nash

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.

1:03 pm

Sean Nash

These seem more like concentrate doses, not dialysate doses. Consider renaming.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

1:02 pm

Sean Nash

What is this?

What is this?

1:01 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:00 pm

Sean Nash

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

12:56 pm

Sean Nash

else TD ?

else TD ?

12:55 pm

Sean Nash

This is a structure, not an enumeration.

This is a structure, not an enumeration.

Monday 16 Mar
11:10 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Friday 13 Mar
3:21 pm

Vendor - TEL - Praneeth Bunne

2:47 pm

Vinayakam Mani , Vendor - TEL - Jashwant Gantyada and Sean Nash

2:23 pm

Sean Nash

2:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

1:45 pm

Vinayakam Mani

Can we remove the empty lines after if / else if blocks in this function?

Can we remove the empty lines after if / else if blocks in this function?

1:43 pm

Vinayakam Mani

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
1:31 pm

Vinayakam Mani

11:50 am

Vendor - TEL - Jashwant Gantyada

done changed it.

done changed it.

11:37 am

Vinayakam Mani

Looks the fields are empty and misaligned. fill as needed.

Looks the fields are empty and misaligned. fill as needed.

9:33 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:31 am

Sean Nash

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

9:28 am

Sean Nash

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

9:24 am

Sean Nash

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)? Controller properties already include a min and max field - can we use those?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

9:16 am

Sean Nash

Remove blank line.

Remove blank line.