leahi-fwcommon

Clone Tools

Stats

Commits this week: 4
Total Committers: 15
Last Commit: 09 Mar
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 23 Jul
4:57 pm

Vendor - TEL - Jashwant Gantyada

11:22 am

Dara Navaei

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?

11:06 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

11:05 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

10:39 am

Dara Navaei

If a retry goes wrong will you trigger an alarm?

If a retry goes wrong will you trigger an alarm?

10:31 am

Dara Navaei

Any fault alarm here?

Any fault alarm here?

10:18 am

Dara Navaei

Have these variables been initialized correctly?

Have these variables been initialized correctly?

9:07 am

Sean Nash

So then no need to initialize it here too. Remove " = FALSE".

So then no need to initialize it here too. Remove " = FALSE".

Wednesday 22 Jul
9:28 pm

Vendor - TEL - Suresh Dharnala

I agree but it is already in the init function.

I agree but it is already in the init function.

1:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

We generally don't add { } to switch cases unless they require local variable declarations.

We generally don't add { } to switch cases unless they require local variable declarations.

1:08 pm

Sean Nash

If we're not including a timestamp, can we just remove this line of code?

If we're not including a timestamp, can we just remove this line of code?

1:07 pm

Sean Nash

Why commented out?

Why commented out?

11:32 am

Sean Nash

Swap order of == for these 2 if statements - put constant on left side.

Swap order of == for these 2 if statements - put constant on left side.

11:19 am

Sean Nash

Why?

Why?

11:16 am

Sean Nash

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

11:14 am

Sean Nash

Use ternary operator to explicitly set to TRUE or FALSE.

Use ternary operator to explicitly set to TRUE or FALSE.

9:31 am

Sean Nash

Our TODO comments are all CAPs.

Our TODO comments are all CAPs.

9:25 am

Sean Nash

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

9:21 am

Sean Nash

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

9:19 am

Sean Nash

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

Should return T/F. Change comment to "TRUE if DD f/w is compatible with TD f/w, FALSE if not.".

9:18 am

Sean Nash

Should return a BOOL (that is what ModeStandby is expecting).

Should return a BOOL (that is what ModeStandby is expecting).

9:18 am

Sean Nash

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

Fix isDDCompatible() function so that it returns a T/F instead of a compatibility revision.

9:16 am

Sean Nash

Align comment.

Align comment.

9:15 am

Sean Nash

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

Tuesday 21 Jul
4:55 pm

Sean Nash

Change INPROGRESS to OPEN (because you're going to remove INPROGRESS).

Change INPROGRESS to OPEN (because you're going to remove INPROGRESS).

4:32 pm

Sean Nash

You can do this sendMessage just once after else.

You can do this sendMessage just once after else.

10:35 am

Vendor - TEL - Arpita Srivastava

add a space before and after 0

add a space before and after 0

10:35 am

Vendor - TEL - Arpita Srivastava

add a blank line above

add a blank line above

10:33 am

Vendor - TEL - Arpita Srivastava

add a blank line above

add a blank line above