Activity leahi-fwcommon/

1:32 pm

Varshini Nagabooshanam <ven.vnagabooshanam@diality.com>

More
b4aa78b
changed 1 file
LDT-3126-blood-prime-td LEAHI-TD-FIRMWARE-LDT-3126-1

LDT-3126-blood-prime-td

- -2
- +3
/TestSupport.h
- History
- Source
- Diff
/TestSupport.h

4:34 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-1473-1
started review

LEAHI-DD-FIRMWARE-LDT-1473_Ultrafiltration - DD

11:26 am

Dara Navaei

More
LEAHI-TD-FIRMWARE-LDT-3126-1
started review

LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD

3:11 pm

Sean Nash

More
LEAHI-FWCOMMON-LDT-2116-1
finished reviewing

3:11 pm

That suggests that our coefficient(s) are too aggressive (in situations where it looks unstable). Not directly due to max step size, so we shouldn't reduce it for this reason. I believe 25 will neg...

That suggests that our coefficient(s) are too aggressive (in situations where it looks unstable). Not directly due to max step size, so we shouldn't reduce it for this reason. I believe 25 will negatively impact our responsiveness in situations where our error is larger than 25 mL/min.
So instability could be due to:
1) coefficient(s) are too strong or
2) may need more than one set of coefficients (e.g. coefficients need to change according to Qd or state or ... because the relationship between output and feedback changes)

11:00 am

Michael Garthwaite

increasing it to 50 would cause instability in our testing. 25 seems to keep it stable at the moment

11:25 am

Raghu Kallala

11:15 am

Dara Navaei

More
38607e6
changed 1 file
LDT-1473-ultrafiltration---dd-2, LDT-2185-io-fp-water-treatment-and-degas and 4 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/PIControllers.c
- History
- Source
- Diff
/PIControllers.c

10:59 am

Raghu Kallala

More
eb50b6a
changed 1 file
LDT-1473-ultrafiltration---dd-2, LDT-2185-io-fp-water-treatment-and-degas and 4 more

LDT-2936 merge into staging

- -5
- +5
/PIControllers.c
- History
- Source
- Diff
/PIControllers.c

10:43 am

Sean Nash , Vinayakam Mani and Michael Garthwaite

More
LEAHI-DD-FIRMWARE-LDT-2936-1
finished reviewing

10:29 am

Raghu Kallala

Resolved

10:16 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2936-1
commented on review

Change comment from 3 to 5 minutes to match code.

10:14 am

Sean Nash

I don't see fix

10:03 am

Raghu Kallala

Fixed the ordering

3:01 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2936-1
commented on review

I'm confused as to why the available alarm that this alarm replaced is in a different row within this table. That seems wrong.

1:26 pm

Dara Navaei

More
36f96b1
changed 29 files
LDT-1473-ultrafiltration---dd-2, LDT-2185-io-fp-water-treatment-and-degas and 4 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -5
- +5
/AlarmMgmt.c
- History
- Source
- Diff
/AlarmMgmt.c
- -5
- +5
/AlarmMgmt.h
- History
- Source
- Diff
/AlarmMgmt.h
- -3
- +3
/Comm.c
- History
- Source
- Diff
/Comm.c
- -4
- +4
/Comm.h
- History
- Source
- Diff
/Comm.h
- -5
- +5
/CommBuffers.c
- History
- Source
- Diff
/CommBuffers.c
- -5
- +5
/CommBuffers.h
- History
- Source
- Diff
/CommBuffers.h
- -5
- +5
/Common.h
- History
- Source
- Diff
/Common.h
- -3
- +3
/FPGA.c
- History
- Source
- Diff
/FPGA.c
- -3
- +3
/FPGA.h
- History
- Source
- Diff
/FPGA.h
- -4
- +4
/MessagePayloads.h
- History
- Source
- Diff
/MessagePayloads.h
- -5
- +5
/MessageSupport.c
- History
- Source
- Diff
/MessageSupport.c
- -5
- +5
/MessageSupport.h
- History
- Source
- Diff
/MessageSupport.h
- -4
- +4
/PIControllers.c
- History
- Source
- Diff
/PIControllers.c
- -4
- +4
/PIControllers.h
- History
- Source
- Diff
/PIControllers.h
- -5
- +5
/PersistentAlarm.c
- History
- Source
- Diff
/PersistentAlarm.c
… 14 more files in changeset.

10:18 am

Raghu Kallala

Handled in FPOperationModes and respective states of PreGen have it.

10:17 am

Raghu Kallala

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

10:15 am

Raghu Kallala

Fixed. Thanks

10:14 am

Raghu Kallala

Fixed.

10:11 am

Raghu Kallala

Fixed.

10:10 am

Raghu Kallala

Fixed. thanks

9:00 am

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-2936-1
commented on review

I don't think the number of samples is what you want as 3rd parameter. You want number of bytes so 4 x number of samples so you should pass "sizeof( roRRSamples )".

8:57 am