leahi-common

DDDefs.h

Clone Tools

Stats

Commits this week: 5
Total Committers: 11
Last Commit: 13:01
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
6 hrs ago

Vendor - TEL - Jashwant Gantyada

done. added a TODO.

done. added a TODO.

6 hrs ago

Vendor - TEL - Jashwant Gantyada

I have added the mentioned ones.

I have added the mentioned ones.

6 hrs ago

Vendor - TEL - Jashwant Gantyada

done.

done.

6 hrs ago

Vendor - TEL - Jashwant Gantyada

done.

done.

6 hrs ago

Vendor - TEL - Jashwant Gantyada

done.

done.

6 hrs ago

Vendor - TEL - Jashwant Gantyada

I didn't make this requested change as this will be removed later as they are for beta 1.9

I didn't make this requested change as this will be removed later as they are for beta 1.9

6 hrs ago

Vendor - TEL - Jashwant Gantyada

done

done

6 hrs ago

Vendor - TEL - Jashwant Gantyada

done

done

6 hrs ago

Vendor - TEL - Jashwant Gantyada

added a todo.

added a todo.

6 hrs ago

Vendor - TEL - Jashwant Gantyada

removed.

removed.

6 hrs ago

Vendor - TEL - Jashwant Gantyada

got it.

got it.

6 hrs ago

Vendor - TEL - Jashwant Gantyada

updated. will do the testing.

updated. will do the testing.

6 hrs ago

Michael Garthwaite

8 hrs ago

Vinayakam Mani

we can start with 500msec. if we change the speed during runtime, say 10% to 20% PWM, need to see how long it takes to stabilize and accordingly this persistence can be set.

we can start with 500msec. if we change the speed during runtime, say 10% to 20% PWM, need to see how long it takes to stabilize and accordingly this persistence can be set.

11 hrs ago

Raghu Kallala

Vinay, based on your work with rinsepump, Do you have any persistence value in mind?

Vinay, based on your work with rinsepump, Do you have any persistence value in mind?

Friday 13 Feb
5:08 pm

Vinayakam Mani

Can we check some persistence before declaring alarm?

Can we check some persistence before declaring alarm?

5:07 pm

Vinayakam Mani

recommend running the pump at few sample speeds and observe the measured feedback and fix the tolerance number.

recommend running the pump at few sample speeds and observe the measured feedback and fix the tolerance number.

4:46 pm

Vinayakam Mani

Rinse pump fault? do we have one? remove concentrate references, commented codes, empty lines.

Rinse pump fault? do we have one? remove concentrate references, commented codes, empty lines.

9:40 am

Vinayakam Mani

Thursday 12 Feb
5:09 pm

Vinayakam Mani

For B1.0/B1.9 - Where Diener silencer 2000 pumps, this macro needs to be enabled.

For B1.0/B1.9 - Where Diener silencer 2000 pumps, this macro needs to be enabled.

5:07 pm

Vinayakam Mani

There are recent changes done on FPGA register in staging for B1.0/B1.9. please merge the latest changes here.

There are recent changes done on FPGA register in staging for B1.0/B1.9. please merge the latest changes here.

4:56 pm

Vinayakam Mani

Add valve details per HDD (may be 2.0 valves. as we remove beta 1/1.9 in sometime)

Add valve details per HDD (may be 2.0 valves. as we remove beta 1/1.9 in sometime)

4:55 pm

Vinayakam Mani

add new valves.

add new valves.

4:53 pm

Vinayakam Mani

Can we follow the same terminology as DD, starting a variable with 'fpga...'. for all IOFP variables?

Can we follow the same terminology as DD, starting a variable with 'fpga...'. for all IOFP variables?

4:50 pm

Vinayakam Mani

typo - used.

typo - used.

4:46 pm

Vinayakam Mani

Add as HDF hallsensor. start the comment with capital letter R.

Add as HDF hallsensor. start the comment with capital letter R.

4:30 pm

Vinayakam Mani

#define 0U across the file.

#define 0U across the file.

4:18 pm

Vinayakam Mani

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we nee...

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we need to add the application code as well now, say if leak is found, trigger an alarm?

3:56 pm

Vinayakam Mani

either typecast pwmInCount as U08 while passing to FPGA or declare the variable size as U08 instead of U32.

either typecast pwmInCount as U08 while passing to FPGA or declare the variable size as U08 instead of U32.

3:50 pm

Vinayakam Mani

Add a variable to convert PWM count to target speed for monitor function.

Add a variable to convert PWM count to target speed for monitor function.