Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
In comment, specify units is % duty cycle (0..100%).

In comment, specify units is % duty cycle (0..100%).

Should we specify that power level is now a duty cycle percentage (0..100%)?

Should we specify that power level is now a duty cycle percentage (0..100%)?

We have a FRACTION_TO_PERCENT_FACTOR in Common.h that we can use when we need 100.0.

We have a FRACTION_TO_PERCENT_FACTOR in Common.h that we can use when we need 100.0.

We've been using capital F. Let's be consistent.

We've been using capital F. Let's be consistent.

Don't call function in function call. Set local var to scalar, then pass local var as param.

Don't call function in function call. Set local var to scalar, then pass local var as param.

You can use RANGE macro in Common.h for this.

You can use RANGE macro in Common.h for this.

( F32 percentage ) { }

( F32 percentage )
{
}

Add space around () i.e. ..Scalar( F32 percentage );

Add space around () i.e. ..Scalar( F32 percentage );

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
No, Yes for lowering event. Fill event uses PWM 150 always irrespective of Qb and Venous pressure only lower event used equation based PWM and that is in the range of 60-250 , not default., based ...

No, Yes for lowering event.

Fill event uses PWM 150 always irrespective of Qb and Venous pressure
only lower event used equation based PWM and that is in the range of 60-250 , not default., based on venous pressure it changes

Do we ever want to use the default (250)? Do we always want to use this venous pressure based power level?

Do we ever want to use the default (250)? Do we always want to use this venous pressure based power level?

Why not for release?

Why not for release?

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
LEAHI-TD-FIRMWARE-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 96 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 15 more files in changeset.
Merge branch 'staging' into LDT-1886-blood-set-auto-load-and-auto-eject-implement-ejector-sensor

  1. … 15 more files in changeset.
We tend to initialize the local variables as a standard practice.

We tend to initialize the local variables as a standard practice.

These don't need to be initialized to zero.

These don't need to be initialized to zero.

Done

Done

Done

Done

Done

Done