td-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 7
Total Committers: 9
Last Commit: 20 Feb
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Feb
1:14 pm

Sean Nash

Update inputs/outputs after updating function.

Update inputs/outputs after updating function.

1:14 pm

Sean Nash

We need to look for user request to resume from pause where we would restart BP (at last rate we were at before pause) and re-open art/ven pinch valves and transition back to either ramp or run sta...

We need to look for user request to resume from pause where we would restart BP (at last rate we were at before pause) and re-open art/ven pinch valves and transition back to either ramp or run state (whichever state we were in when we paused).

1:14 pm

Sean Nash

In this state, we still need to signal transition to dialysis when target volume is reached (same as in ramp state). We also need to look for user request to pause (same as in ramp state).

In this state, we still need to signal transition to dialysis when target volume is reached (same as in ramp state).
We also need to look for user request to pause (same as in ramp state).

1:12 pm

Sean Nash

We do need an else if here for when user does change the blood flow rate. In that case, we would want to go to run state where we would run continuously at the requested rate without ramping anymor...

We do need an else if here for when user does change the blood flow rate. In that case, we would want to go to run state where we would run continuously at the requested rate without ramping anymore. Ask Nico which message UI sends when user changes blood flow rate.

And we need another else if for when user asks to pause blood prime and we would stop BP (and maybe close art/ven pinch valves) and go to pause state.

1:10 pm

Sean Nash

Input and Output is cumulativeBloodPrimevolume_mL.

Input and Output is cumulativeBloodPrimevolume_mL.

1:07 pm

Sean Nash

signal function will take us out of blood prime, so no reason to change state here. We would not want to go to run state even if we weren't leaving - run state is for when user changes blood flow r...

signal function will take us out of blood prime, so no reason to change state here. We would not want to go to run state even if we weren't leaving - run state is for when user changes blood flow rate which they have not done here.

1:05 pm

Sean Nash

Raghu is fixing this in his Tx Params branch, but you should fix it too. TUBING_BLOOD_PRIME_VOLUME_ML is not a treatment parameter. See Raghu's fix and duplicate it here.

Raghu is fixing this in his Tx Params branch, but you should fix it too. TUBING_BLOOD_PRIME_VOLUME_ML is not a treatment parameter. See Raghu's fix and duplicate it here.

12:49 pm

Sean Nash

12:49 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
11:32 am

Sean Nash

In comment, specify units is % duty cycle (0..100%).

In comment, specify units is % duty cycle (0..100%).

11:31 am

Sean Nash

Should we specify that power level is now a duty cycle percentage (0..100%)?

Should we specify that power level is now a duty cycle percentage (0..100%)?

11:25 am

Sean Nash

We have a FRACTION_TO_PERCENT_FACTOR in Common.h that we can use when we need 100.0.

We have a FRACTION_TO_PERCENT_FACTOR in Common.h that we can use when we need 100.0.

11:22 am

Sean Nash

We've been using capital F. Let's be consistent.

We've been using capital F. Let's be consistent.

11:21 am

Sean Nash

Don't call function in function call. Set local var to scalar, then pass local var as param.

Don't call function in function call. Set local var to scalar, then pass local var as param.

11:10 am

Sean Nash

You can use RANGE macro in Common.h for this.

You can use RANGE macro in Common.h for this.

11:07 am

Sean Nash

( F32 percentage ) { }

( F32 percentage )
{
}

11:06 am

Sean Nash

Add space around () i.e. ..Scalar( F32 percentage );

Add space around () i.e. ..Scalar( F32 percentage );

9:40 am

Sean Nash

9:40 am

Vendor - TEL - Sameer Poyil

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
Wednesday 18 Feb
9:56 pm

Sean Nash

Just a heads up that all message handling functions in Leahi have the same prototype - just different function names (i.e. BOOL funcName( MESSAGE_T *message)) and that includes all Dialin command m...

Just a heads up that all message handling functions in Leahi have the same prototype - just different function names (i.e. BOOL funcName( MESSAGE_T *message)) and that includes all Dialin command message handlers like these.

9:48 pm

Sean Nash

This param has been renamed to HEPARIN_STOP_TIME which is a couple rows below so we don't need to add this.

This param has been renamed to HEPARIN_STOP_TIME which is a couple rows below so we don't need to add this.

9:47 pm

Sean Nash

We will not have this saline bolus state in Leahi.

We will not have this saline bolus state in Leahi.

11:32 am

Vendor - TEL - Arpita Srivastava

This code review contains known issues, and it is not yet ready for a detailed review.

This code review contains known issues, and it is not yet ready for a detailed review.

Tuesday 17 Feb
9:53 am

Vendor - TEL - Sameer Poyil

Friday 13 Feb
3:51 pm

Vendor - TEL - Sameer Poyil

No, Yes for lowering event. Fill event uses PWM 150 always irrespective of Qb and Venous pressure only lower event used equation based PWM and that is in the range of 60-250 , not default., based ...

No, Yes for lowering event.

Fill event uses PWM 150 always irrespective of Qb and Venous pressure
only lower event used equation based PWM and that is in the range of 60-250 , not default., based on venous pressure it changes

2:11 pm

Sean Nash

Do we ever want to use the default (250)? Do we always want to use this venous pressure based power level?

Do we ever want to use the default (250)? Do we always want to use this venous pressure based power level?

2:09 pm

Sean Nash

Why not for release?

Why not for release?

2:03 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:03 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:00 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.