td-firmware / firmware / App / Services

Messaging.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 7
Last Commit: 20 Feb
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Feb
1:14 pm

Sean Nash

Update inputs/outputs after updating function.

Update inputs/outputs after updating function.

1:14 pm

Sean Nash

We need to look for user request to resume from pause where we would restart BP (at last rate we were at before pause) and re-open art/ven pinch valves and transition back to either ramp or run sta...

We need to look for user request to resume from pause where we would restart BP (at last rate we were at before pause) and re-open art/ven pinch valves and transition back to either ramp or run state (whichever state we were in when we paused).

1:14 pm

Sean Nash

In this state, we still need to signal transition to dialysis when target volume is reached (same as in ramp state). We also need to look for user request to pause (same as in ramp state).

In this state, we still need to signal transition to dialysis when target volume is reached (same as in ramp state).
We also need to look for user request to pause (same as in ramp state).

1:12 pm

Sean Nash

We do need an else if here for when user does change the blood flow rate. In that case, we would want to go to run state where we would run continuously at the requested rate without ramping anymor...

We do need an else if here for when user does change the blood flow rate. In that case, we would want to go to run state where we would run continuously at the requested rate without ramping anymore. Ask Nico which message UI sends when user changes blood flow rate.

And we need another else if for when user asks to pause blood prime and we would stop BP (and maybe close art/ven pinch valves) and go to pause state.

1:10 pm

Sean Nash

Input and Output is cumulativeBloodPrimevolume_mL.

Input and Output is cumulativeBloodPrimevolume_mL.

1:07 pm

Sean Nash

signal function will take us out of blood prime, so no reason to change state here. We would not want to go to run state even if we weren't leaving - run state is for when user changes blood flow r...

signal function will take us out of blood prime, so no reason to change state here. We would not want to go to run state even if we weren't leaving - run state is for when user changes blood flow rate which they have not done here.

1:05 pm

Sean Nash

Raghu is fixing this in his Tx Params branch, but you should fix it too. TUBING_BLOOD_PRIME_VOLUME_ML is not a treatment parameter. See Raghu's fix and duplicate it here.

Raghu is fixing this in his Tx Params branch, but you should fix it too. TUBING_BLOOD_PRIME_VOLUME_ML is not a treatment parameter. See Raghu's fix and duplicate it here.

12:49 pm

Sean Nash

12:49 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
Thursday 12 Feb
5:35 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Messaging.c
  2. … 2 more files in changeset.
5:15 pm

Vendor - TEL - Jashwant Gantyada

4:57 pm

Sean Nash and Vendor - TEL - Sameer Poyil

3:07 pm

Vendor - TEL - Jashwant Gantyada

It was typo. Updated it.

It was typo. Updated it.

3:02 pm

Sean Nash

This doesn't look right. Status = time?

This doesn't look right. Status = time?

2:10 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

2:10 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

2:10 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

2:10 pm

Vendor - TEL - Jashwant Gantyada

done

done

Tuesday 03 Feb
1:02 pm

Vendor - TEL - Varshini Nagabooshanam

Monday 02 Feb
4:44 pm

Vendor - TEL - Sameer Poyil

input parameter not updated

input parameter not updated

4:44 pm

Vendor - TEL - Sameer Poyil

input parameter is not updated

input parameter is not updated

4:40 pm

Vendor - TEL - Sameer Poyil

input and output is not updated properly

input and output is not updated properly

4:33 pm

Vendor - TEL - Sameer Poyil

structure packing required

structure packing required

4:26 pm

Vendor - TEL - Jashwant Gantyada

Thursday 29 Jan
2:02 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:53 pm

Sean Nash

Please keep local declarations together up top.

Please keep local declarations together up top.

1:49 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

1:49 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:06 pm

Sean Nash

I would make another local variable (BOOL) above and set it per trinary operation and then pass the BOOL to the function. I think we want to avoid complex logic or function calls as a function para...

I would make another local variable (BOOL) above and set it per trinary operation and then pass the BOOL to the function.
I think we want to avoid complex logic or function calls as a function parameter per our coding standards.

1:03 pm

Sean Nash

Remove blank line.

Remove blank line.