td-firmware / firmware / App

TDCommon.h

Clone Tools

Stats

Commits this week: 9
Total Committers: 5
Last Commit: 20 Feb
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 Feb
11:32 am

Sean Nash

In comment, specify units is % duty cycle (0..100%).

In comment, specify units is % duty cycle (0..100%).

11:31 am

Sean Nash

Should we specify that power level is now a duty cycle percentage (0..100%)?

Should we specify that power level is now a duty cycle percentage (0..100%)?

11:25 am

Sean Nash

We have a FRACTION_TO_PERCENT_FACTOR in Common.h that we can use when we need 100.0.

We have a FRACTION_TO_PERCENT_FACTOR in Common.h that we can use when we need 100.0.

11:22 am

Sean Nash

We've been using capital F. Let's be consistent.

We've been using capital F. Let's be consistent.

11:21 am

Sean Nash

Don't call function in function call. Set local var to scalar, then pass local var as param.

Don't call function in function call. Set local var to scalar, then pass local var as param.

11:10 am

Sean Nash

You can use RANGE macro in Common.h for this.

You can use RANGE macro in Common.h for this.

11:07 am

Sean Nash

( F32 percentage ) { }

( F32 percentage )
{
}

11:06 am

Sean Nash

Add space around () i.e. ..Scalar( F32 percentage );

Add space around () i.e. ..Scalar( F32 percentage );

9:40 am

Sean Nash

9:40 am

Vendor - TEL - Sameer Poyil

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
Tuesday 17 Feb
9:53 am

Vendor - TEL - Sameer Poyil

Friday 13 Feb
3:51 pm

Vendor - TEL - Sameer Poyil

No, Yes for lowering event. Fill event uses PWM 150 always irrespective of Qb and Venous pressure only lower event used equation based PWM and that is in the range of 60-250 , not default., based ...

No, Yes for lowering event.

Fill event uses PWM 150 always irrespective of Qb and Venous pressure
only lower event used equation based PWM and that is in the range of 60-250 , not default., based on venous pressure it changes

2:11 pm

Sean Nash

Do we ever want to use the default (250)? Do we always want to use this venous pressure based power level?

Do we ever want to use the default (250)? Do we always want to use this venous pressure based power level?

2:09 pm

Sean Nash

Why not for release?

Why not for release?

2:03 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:03 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:00 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:33 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
Thursday 12 Feb
5:36 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
Tuesday 10 Feb
3:32 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
Wednesday 04 Feb
5:19 pm

Dara Navaei

Bamboo Commit: Updated TDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./TDCommon.h
4:59 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./TDCommon.h
  2. … 7 more files in changeset.
4:57 pm

Vendor - TEL - Varshini Nagabooshanam

4:53 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

4:36 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
2:34 pm

Vendor - TEL - Varshini Nagabooshanam

Commented out already but I dont know why it is showing the same

Commented out already but I dont know why it is showing the same

2:34 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-1415-pressures-monitoring-td

Options
    • -1
    • +1
    ./TDCommon.h
2:10 pm

Sean Nash

It's still UI only. Shouldn't this be commented out before we merge?

It's still UI only. Shouldn't this be commented out before we merge?

12:05 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, updated

Yes, updated

12:05 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed