td-firmware / firmware / App / Monitors

Bubbles.c

Clone Tools

Stats

Commits this week: 5
Total Committers: 6
Last Commit: 13 Mar
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 13 Mar
3:21 pm

Vendor - TEL - Praneeth Bunne

2:47 pm

Vinayakam Mani , Vendor - TEL - Jashwant Gantyada and Sean Nash

2:23 pm

Sean Nash

1:45 pm

Vinayakam Mani

Can we remove the empty lines after if / else if blocks in this function?

Can we remove the empty lines after if / else if blocks in this function?

11:43 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Bubbles.c
11:30 am

Vendor - TEL - Varshini Nagabooshanam

11:28 am

Dara Navaei

Wednesday 11 Mar
3:31 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD
LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD
Friday 20 Feb
1:48 pm

Sean Nash

1:08 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

1:02 pm

Sean Nash

But now it's not in right position (in this table only). This table should be sorted by rank.

But now it's not in right position (in this table only). This table should be sorted by rank.

12:13 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:12 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

11:37 am

Sean Nash

This was correct before (assuming 711 was correct rank).

This was correct before (assuming 711 was correct rank).

11:36 am

Sean Nash

Why change rank back to 206? If priority is low, rank was probably correct at 711. I think you had correct properties before - it was just in the wrong row.

Why change rank back to 206? If priority is low, rank was probably correct at 711. I think you had correct properties before - it was just in the wrong row.

10:23 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:23 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Wednesday 18 Feb
9:45 pm

Sean Nash

This alarm does not belong here. Put it back where it was before. In the next table below, the alarms are sorted by rank. But this property table is sorted by alarm ID #.

This alarm does not belong here. Put it back where it was before.
In the next table below, the alarms are sorted by rank. But this property table is sorted by alarm ID #.

9:43 pm

Sean Nash

Why did you move it. The alarm is #30 so it should stay here where you had it before.

Why did you move it. The alarm is #30 so it should stay here where you had it before.

Tuesday 17 Feb
11:48 am

Vendor - TEL - Varshini Nagabooshanam

Based on the Denali properties, I have written the following.

Based on the Denali properties, I have written the following.

10:07 am

Sean Nash

Priority doesn't look right. Should be High I think. Check properties from Denali project.

Priority doesn't look right. Should be High I think. Check properties from Denali project.

10:00 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3539_Air Infusion - TD
LEAHI-TD-FIRMWARE-LDT-3539_Air Infusion - TD
8:55 am

Vendor - TEL - Varshini Nagabooshanam

LDT-3539-air-infusion-td

Options
    • -1
    • +1
    ./Bubbles.c
Thursday 12 Feb
5:35 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Bubbles.c
  2. … 2 more files in changeset.
5:15 pm

Vendor - TEL - Jashwant Gantyada

4:57 pm

Sean Nash and Vendor - TEL - Sameer Poyil

3:07 pm

Vendor - TEL - Jashwant Gantyada

It was typo. Updated it.

It was typo. Updated it.

3:06 pm

Vendor - TEL - Jashwant Gantyada

LDT-2749 addressed code review comments

Options
    • -1
    • +1
    ./Bubbles.c
3:02 pm

Sean Nash

This doesn't look right. Status = time?

This doesn't look right. Status = time?

2:10 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.